MacGui: Added Deblock to filters in Picture Preview Window

- Currently uses a checkbox that enables pp7 (default settings)

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1046 b64f7644-9d1e-0410-96f1-a4d463321fa5

diff --git a/macosx/Controller.h b/macosx/Controller.h
index 68c8f672eb221bbd7cd9efb2dcabecfd71a96302..a44e156784b79f8691ffa49771dffc0a103287f0 100644 (file)
--- a/macosx/Controller.h
+++ b/macosx/Controller.h
@@ -91,6 +91,7 @@
     IBOutlet NSTextField         * fPicLabelDetelecine;
        IBOutlet NSTextField         * fPicLabelDeinterlace;
     IBOutlet NSTextField         * fPicLabelDenoise;
+    IBOutlet NSTextField         * fPicLabelDeblock;
        
        IBOutlet NSTextField         * fPicSrcWidth;
        IBOutlet NSTextField         * fPicSrcHeight;
@@ -102,6 +103,7 @@
        IBOutlet NSTextField         * fPicSettingAutoCrop;
        IBOutlet NSTextField         * fPicSettingDetelecine;
        IBOutlet NSTextField         * fPicSettingDenoise;
+    IBOutlet NSTextField         * fPicSettingDeblock;
 
        IBOutlet NSTextField         * fPicLabelAnamorphic;
        IBOutlet NSTextField         * fPicLabelPAROutputX;

diff --git a/macosx/Controller.mm b/macosx/Controller.mm
index 29d19701944a98c30b8cf5f0fc2f0d57c96e078c..1ae602f300a85439e39b54cab6668138c73cf528 100644 (file)
--- a/macosx/Controller.mm
+++ b/macosx/Controller.mm
@@ -362,7 +362,8 @@ static NSString *        ChooseSourceIdentifier             = @"Choose Source It
                fPicLabelPAROutputX,fPicSettingPARWidth,fPicSettingPARHeight,
                fPicSettingPAR,fPicLabelAnamorphic,tableView,fPresetsAdd,fPresetsDelete,
                fCreateChapterMarkers,fVidTurboPassCheck,fDstMpgLargeFileCheck,fPicLabelAutoCrop,
-               fPicSettingAutoCrop,fPicSettingDetelecine,fPicLabelDetelecine,fPicLabelDenoise,fPicSettingDenoise,fSubForcedCheck,};
+               fPicSettingAutoCrop,fPicSettingDetelecine,fPicLabelDetelecine,fPicLabelDenoise,fPicSettingDenoise,
+        fSubForcedCheck,fPicSettingDeblock,fPicLabelDeblock,};
 
     for( unsigned i = 0;
          i < sizeof( controls ) / sizeof( NSControl * ); i++ )
@@ -1403,7 +1404,8 @@ static NSString *        ChooseSourceIdentifier             = @"Choose Source It
     job->arate = hb_audio_rates[[fAudRatePopUp
                      indexOfSelectedItem]].rate;
     job->abitrate = [[fAudBitratePopUp selectedItem] tag];
-    
+   
+    /* Filters */ 
     job->filters = hb_list_init();
    
        /* Detelecine */
@@ -1455,6 +1457,12 @@ static NSString *        ChooseSourceIdentifier             = @"Choose Source It
                hb_filter_denoise.settings = "7:7:5:5"; 
         hb_list_add( job->filters, &hb_filter_denoise );       
        }
+    
+    /* Deblock  (uses pp7 default) */
+    if ([fPictureController deblock])
+    {
+        hb_list_add( job->filters, &hb_filter_deblock );
+    }
 
 }
 
@@ -2460,6 +2468,14 @@ the user is using "Custom" settings by determining the sender*/
        {
                [fPicSettingDenoise setStringValue: @"Strong"];
        }
+
+    /* Deblock */
+    if ([fPictureController deblock]) {
+        [fPicSettingDeblock setStringValue: @"Yes"];
+    }
+    else {
+        [fPicSettingDeblock setStringValue: @"No"];
+    }
        
        if (fTitle->job->pixel_ratio > 0)
        {

diff --git a/macosx/English.lproj/MainMenu.nib/classes.nib b/macosx/English.lproj/MainMenu.nib/classes.nib
index 4e2cb1f1398f4381bdf96fd307e519c8ac01cfc5..0bbfcb88121386bf63c5307ff4b4c95f494cb2cf 100644 (file)
--- a/macosx/English.lproj/MainMenu.nib/classes.nib
+++ b/macosx/English.lproj/MainMenu.nib/classes.nib
@@ -133,6 +133,7 @@
                 fPicLabelAnamorphic = NSTextField; 
                 fPicLabelAr = NSTextField; 
                 fPicLabelAutoCrop = NSTextField; 
+                fPicLabelDeblock = NSTextField; 
                 fPicLabelDeinterlace = NSTextField; 
                 fPicLabelDenoise = NSTextField; 
                 fPicLabelDetelecine = NSTextField; 
@@ -144,6 +145,7 @@
                 fPicLabelSrcX = NSTextField; 
                 fPicSettingARkeep = NSTextField; 
                 fPicSettingAutoCrop = NSTextField; 
+                fPicSettingDeblock = NSTextField; 
                 fPicSettingDeinterlace = NSTextField; 
                 fPicSettingDenoise = NSTextField; 
                 fPicSettingDetelecine = NSTextField; 

diff --git a/macosx/English.lproj/MainMenu.nib/info.nib b/macosx/English.lproj/MainMenu.nib/info.nib
index 843e90af9836b79d98f2e4ea74cc02d2e0a9263e..f94a50806497608f59364392018142b642ab5268 100644 (file)
--- a/macosx/English.lproj/MainMenu.nib/info.nib
+++ b/macosx/English.lproj/MainMenu.nib/info.nib
@@ -7,7 +7,7 @@
        <key>IBEditorPositions</key>
        <dict>
                <key>1843</key>
-               <string>640 320 200 530 0 0 1440 878 </string>
+               <string>620 338 200 530 0 0 1440 878 </string>
                <key>2436</key>
                <string>307 361 192 68 0 0 1440 878 </string>
                <key>29</key>
@@ -27,9 +27,8 @@
        <integer>4</integer>
        <key>IBOpenObjects</key>
        <array>
-               <integer>1843</integer>
-               <integer>21</integer>
                <integer>29</integer>
+               <integer>21</integer>
        </array>
        <key>IBSystem Version</key>
        <string>8R2218</string>

diff --git a/macosx/English.lproj/MainMenu.nib/keyedobjects.nib b/macosx/English.lproj/MainMenu.nib/keyedobjects.nib
index 12c88cb09c3ffcc1071f67516d61a2d9e3990f77..5327c4cda6c5a891697143230f1afd34ad9f1192 100644 (file)
Binary files a/macosx/English.lproj/MainMenu.nib/keyedobjects.nib and b/macosx/English.lproj/MainMenu.nib/keyedobjects.nib differ

diff --git a/macosx/English.lproj/PictureSettings.nib/classes.nib b/macosx/English.lproj/PictureSettings.nib/classes.nib
index bf6661763f994539f7357dcc6cd47c2a125d78c5..7f70da0e6622e70002b136ce9dc6a66135c38f06 100644 (file)
--- a/macosx/English.lproj/PictureSettings.nib/classes.nib
+++ b/macosx/English.lproj/PictureSettings.nib/classes.nib
@@ -23,6 +23,7 @@
                 fCropRightStepper = NSStepper; 
                 fCropTopField = NSTextField; 
                 fCropTopStepper = NSStepper; 
+                fDeblockCheck = NSButton; 
                 fDeinterlacePopUp = NSPopUpButton; 
                 fDenoisePopUp = NSPopUpButton; 
                 fDetelecineCheck = NSButton; 

diff --git a/macosx/English.lproj/PictureSettings.nib/info.nib b/macosx/English.lproj/PictureSettings.nib/info.nib
index df5713deb3f31ae92005090672d3b25fd827932b..332e5df0aab218d382a897d0394dc9c75a6e7fdc 100644 (file)
--- a/macosx/English.lproj/PictureSettings.nib/info.nib
+++ b/macosx/English.lproj/PictureSettings.nib/info.nib
@@ -3,7 +3,7 @@
 <plist version="1.0">
 <dict>
        <key>IBDocumentLocation</key>
-       <string>715 90 356 240 0 0 1920 1178 </string>
+       <string>496 129 356 240 0 0 1440 878 </string>
        <key>IBFramework Version</key>
        <string>446.1</string>
        <key>IBOpenObjects</key>

diff --git a/macosx/English.lproj/PictureSettings.nib/keyedobjects.nib b/macosx/English.lproj/PictureSettings.nib/keyedobjects.nib
index 619172b48e3ce4f22e45dc32151d58ac941be0c2..f8570e07fbee5a032caaa69de147a91a0499e942 100644 (file)
Binary files a/macosx/English.lproj/PictureSettings.nib/keyedobjects.nib and b/macosx/English.lproj/PictureSettings.nib/keyedobjects.nib differ

diff --git a/macosx/HandBrake.xcodeproj/project.pbxproj b/macosx/HandBrake.xcodeproj/project.pbxproj
index 1e884789405cd41203d7cbebf2909db6d4002a9f..bf4545047a8d4d6a40416df999857daefc96c738 100644 (file)
--- a/macosx/HandBrake.xcodeproj/project.pbxproj
+++ b/macosx/HandBrake.xcodeproj/project.pbxproj
@@ -215,7 +215,7 @@
 /* Begin PBXFileReference section */
                089C165DFE840E0CC02AAC07 /* English */ = {isa = PBXFileReference; fileEncoding = 10; lastKnownFileType = text.plist.strings; name = English; path = English.lproj/InfoPlist.strings; sourceTree = "<group>"; };
                0D096DFF0B707D1200A845D4 /* libhb.dylib */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.dylib"; includeInIndex = 0; path = libhb.dylib; sourceTree = BUILT_PRODUCTS_DIR; };
-               0D6E35760B6BD4F0005AABB3 /* HandBrake.app */ = {isa = PBXFileReference; includeInIndex = 0; lastKnownFileType = wrapper.application; path = HandBrake.app; sourceTree = BUILT_PRODUCTS_DIR; };
+               0D6E35760B6BD4F0005AABB3 /* HandBrake.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = HandBrake.app; sourceTree = BUILT_PRODUCTS_DIR; };
                0DF377970B7BF99A00115CB0 /* fakexcode.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; name = fakexcode.cpp; path = ../test/fakexcode.cpp; sourceTree = SOURCE_ROOT; };
                0DFA5C7A0B8DD1E90020BC09 /* HandBrake.icns */ = {isa = PBXFileReference; lastKnownFileType = image.icns; path = HandBrake.icns; sourceTree = "<group>"; };
                0DFA5C7E0B8DD3B60020BC09 /* declpcm.c */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.c; name = declpcm.c; path = ../libhb/declpcm.c; sourceTree = SOURCE_ROOT; };

diff --git a/macosx/PictureController.h b/macosx/PictureController.h
index 4c13a06fc5ba5e43ee5b56b69ed4a74fb8808d45..62e78af4a2ae65868e54bf298d8bf2688ad541e2 100644 (file)
--- a/macosx/PictureController.h
+++ b/macosx/PictureController.h
@@ -41,6 +41,7 @@
     IBOutlet NSStepper       * fCropRightStepper;
     IBOutlet NSPopUpButton   * fDeinterlacePopUp;
        IBOutlet NSButton        * fDetelecineCheck;
+    IBOutlet NSButton        * fDeblockCheck;
        IBOutlet NSPopUpButton   * fDenoisePopUp;
        IBOutlet NSButton        * fPARCheck;
     IBOutlet NSButton        * fEffectsCheck;
@@ -62,6 +63,7 @@
         int    detelecine;
         int     deinterlace;
         int     denoise;
+        int     deblock;
     } fPictureFilterSettings;
 
     id delegate;
@@ -86,6 +88,8 @@
 - (void) setDeinterlace: (int) setting;
 - (int) denoise;
 - (void) setDenoise: (int) setting;
+- (int) deblock;
+- (void) setDeblock: (int) setting;
 
 - (void)showPanelInWindow: (NSWindow *)fWindow forTitle: (hb_title_t *)title;
 - (BOOL) loadMyNibFile;

diff --git a/macosx/PictureController.mm b/macosx/PictureController.mm
index 865f1c20246b3963538f78915e9cd437d19b63f3..640479b65cb9436d8e5a06b08cd9231c15d00067 100644 (file)
--- a/macosx/PictureController.mm
+++ b/macosx/PictureController.mm
@@ -306,6 +306,7 @@ static int GetAlignedSize( int size )
     }
     fPictureFilterSettings.denoise     = [fDenoisePopUp indexOfSelectedItem];
     fPictureFilterSettings.detelecine  = [fDetelecineCheck state];
+    fPictureFilterSettings.deblock  = [fDeblockCheck state];
        job->pixel_ratio = ( [fPARCheck state] == NSOnState );
 
     autoCrop = ( [fCropMatrix selectedRow] == 0 );
@@ -438,6 +439,16 @@ static int GetAlignedSize( int size )
     fPictureFilterSettings.denoise = setting;
 }
 
+- (int) deblock
+{
+    return fPictureFilterSettings.deblock;
+}
+
+- (void) setDeblock: (int) setting
+{
+    fPictureFilterSettings.deblock = setting;
+}
+
 - (void)showPanelInWindow: (NSWindow *)fWindow forTitle: (hb_title_t *)title
 {
     [self SetTitle:title];