]> granicus.if.org Git - clang/commitdiff
Fix crash if a literal operator template's template parameter pack is not a non-type...
authorRichard Smith <richard-llvm@metafoo.co.uk>
Fri, 3 Aug 2012 21:14:57 +0000 (21:14 +0000)
committerRichard Smith <richard-llvm@metafoo.co.uk>
Fri, 3 Aug 2012 21:14:57 +0000 (21:14 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@161260 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/literal-operators.cpp

index 35364dca7463df2edad1298a03fb96a210f000a5..8cd134a6a0fc697e0bc51651fcd084705bdbe56b 100644 (file)
@@ -9473,7 +9473,7 @@ bool Sema::CheckLiteralOperatorDeclaration(FunctionDecl *FnDecl) {
       TemplateParameterList *Params = TpDecl->getTemplateParameters();
       if (Params->size() == 1) {
         NonTypeTemplateParmDecl *PmDecl =
-          cast<NonTypeTemplateParmDecl>(Params->getParam(0));
+          dyn_cast<NonTypeTemplateParmDecl>(Params->getParam(0));
 
         // The template parameter must be a char parameter pack.
         if (PmDecl && PmDecl->isTemplateParameterPack() &&
index 7f68cd393cad3c03068270557c82aa4a29642635..f4c5c35a2bcb2ceac1fa4bf44c443e90f1dafcfb 100644 (file)
@@ -41,3 +41,4 @@ void operator "" _cv_good (volatile const char *, const size_t); // expected-err
 template <char...> void operator "" _good ();
 
 // FIXME: Test some invalid decls that might crop up.
+template <typename...> void operator "" _invalid(); // expected-error {{parameter declaration for literal operator 'operator "" _invalid' is not valid}}