mod_http2: returning idle connections back to the mpm in case of async mpm enabled

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1720172 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index a1c24981c09e6abfa6cd873b78e61064f0cd871f..fca8455f06cf1bef58e2bc86269dbfb914357e4b 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,10 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.5.0
 
+  *) mod_http2: when running in async mpm processing, mod_http2 will cease
+     processing on idle connections (e.g. no open streams) back to the mpm.
+     [Stefan Eissing]     
+
   *) mod_http2: fixed bug in input window size calculation by moving chunked
      request body encoding into later stage of processing.
      [Stefan Eissing]

diff --git a/modules/http2/h2_config.c b/modules/http2/h2_config.c
index 5e7af79a6922f2d4419ba624a322cf31f0bb253e..93b6e27ba83cb0d5680a4e2e7bb7b605bbf1dbff 100644 (file)
--- a/modules/http2/h2_config.c
+++ b/modules/http2/h2_config.c
@@ -61,7 +61,8 @@ static h2_config defconf = {
     NULL,                   /* map of content-type to priorities */
 };
 
-static int files_per_session = 0;
+static int files_per_session;
+static int async_mpm;
 
 void h2_config_init(apr_pool_t *pool) {
     /* Determine a good default for this platform and mpm?
@@ -85,6 +86,14 @@ void h2_config_init(apr_pool_t *pool) {
             /* don't know anything about it, stay safe */
             break;
     }
+    if (ap_mpm_query(AP_MPMQ_IS_ASYNC, &async_mpm) != APR_SUCCESS) {
+        async_mpm = 0;
+    }
+}
+
+int h2_config_async_mpm(void)
+{
+    return async_mpm;
 }
 
 static void *h2_config_create(apr_pool_t *pool,

diff --git a/modules/http2/h2_config.h b/modules/http2/h2_config.h
index 3d85ec247d3b9ef3aa7ab0eb4924b74699053cf2..2c688e9c16a99a855d70ddf0c84afc4f6055809c 100644 (file)
--- a/modules/http2/h2_config.h
+++ b/modules/http2/h2_config.h
@@ -87,6 +87,8 @@ void h2_config_init(apr_pool_t *pool);
 
 const struct h2_priority *h2_config_get_priority(const h2_config *conf, 
                                                  const char *content_type);
-                                                 
+       
+int h2_config_async_mpm(void);
+
 #endif /* __mod_h2__h2_config_h__ */
 

diff --git a/modules/http2/h2_conn.c b/modules/http2/h2_conn.c
index 2b8a058d2e9691fab83282ea391eef98125f7e02..21248489548e95a6ae43fec7450c0eada437f282 100644 (file)
--- a/modules/http2/h2_conn.c
+++ b/modules/http2/h2_conn.c
@@ -129,7 +129,6 @@ static module *h2_conn_mpm_module(void) {
 apr_status_t h2_conn_setup(h2_ctx *ctx, conn_rec *c, request_rec *r)
 {
     h2_session *session;
-    const h2_config *config;
     
     if (!workers) {
         ap_log_cerror(APLOG_MARK, APLOG_ERR, 0, c, APLOGNO(02911) 
@@ -137,75 +136,57 @@ apr_status_t h2_conn_setup(h2_ctx *ctx, conn_rec *c, request_rec *r)
         return APR_EGENERAL;
     }
     
-    ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, "h2_conn_setup");
-    config = h2_config_sget(h2_ctx_server_get(ctx));
     if (r) {
-        session = h2_session_rcreate(r, config, workers);
+        session = h2_session_rcreate(r, ctx, workers);
     }
     else {
-        session = h2_session_create(c, config, workers);
+        session = h2_session_create(c, ctx, workers);
     }
 
     h2_ctx_session_set(ctx, session);
+    ap_update_child_status_from_conn(c->sbh, SERVER_BUSY_READ, c);
+
     return APR_SUCCESS;
 }
 
-apr_status_t h2_conn_process(h2_ctx *ctx)
+apr_status_t h2_conn_process(h2_ctx *ctx, int async)
 {
     apr_status_t status;
     h2_session *session;
-    conn_rec *c;
-    int rv;
     
     session = h2_ctx_session_get(ctx);
-    c = session->c;
-    
-    if (!h2_is_acceptable_connection(c, 1)) {
-        nghttp2_submit_goaway(session->ngh2, NGHTTP2_FLAG_NONE, 0,
-                              NGHTTP2_INADEQUATE_SECURITY, NULL, 0);
-    } 
 
-    ap_update_child_status_from_conn(c->sbh, SERVER_BUSY_READ, c);
-    status = h2_session_start(session, &rv);
-    
-    ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, session->c,
-                  "h2_session(%ld): starting on %s:%d", session->id,
-                  session->c->base_server->server_hostname,
-                  session->c->local_addr->port);
-    if (status != APR_SUCCESS) {
-        h2_session_abort(session, status, rv);
-        h2_session_eoc_callback(session);
-        return status;
-    }
-    
-    status = h2_session_process(session);
+    status = h2_session_process(session, async);
 
     if (status == APR_EOF) {
         ap_log_cerror( APLOG_MARK, APLOG_DEBUG, status, session->c,
                       "h2_session(%ld): done", session->id);
         /* Make sure this connection gets closed properly. */
-        ap_update_child_status_from_conn(c->sbh, SERVER_CLOSING, c);
-        c->keepalive = AP_CONN_CLOSE;
-        if (c->cs) {
-            c->cs->state = CONN_STATE_WRITE_COMPLETION;
-        }
+        ap_update_child_status_from_conn(session->c->sbh, SERVER_CLOSING, session->c);
+        session->c->keepalive = AP_CONN_CLOSE;
         
         h2_session_close(session);
         /* hereafter session will be gone */
     }
+    else {
+        session->c->data_in_input_filters = 0;
+        session->c->keepalive = AP_CONN_KEEPALIVE;
+    }
     
-    return status;
+    if (session->c->cs) {
+        session->c->cs->state = CONN_STATE_WRITE_COMPLETION;
+    }
+    
+    return DONE;
 }
 
-apr_status_t h2_conn_run(struct h2_ctx *ctx)
+apr_status_t h2_conn_run(struct h2_ctx *ctx, conn_rec *c)
 {
-    apr_status_t status;
-    
     do {
-        status = h2_conn_process(ctx);
-    } while (status == APR_SUCCESS);
+        h2_conn_process(ctx, 0);
+    } while (c->keepalive == AP_CONN_KEEPALIVE && !c->aborted);
     
-    return (status == APR_EOF)? APR_SUCCESS : status;
+    return DONE;
 }
 
 

diff --git a/modules/http2/h2_conn.h b/modules/http2/h2_conn.h
index c8ecbfd7f043c7ec9f1a8eff2efcf92170c3af35..87bc98c386ab591f4e77ca5acef974c96bcbbe0e 100644 (file)
--- a/modules/http2/h2_conn.h
+++ b/modules/http2/h2_conn.h
@@ -36,16 +36,17 @@ apr_status_t h2_conn_setup(struct h2_ctx *ctx, conn_rec *c, request_rec *r);
  * @return APR_SUCCESS as long as processing needs to continue, APR_EOF
  *         when HTTP/2 session is done.
  */
-apr_status_t h2_conn_process(struct h2_ctx *ctx);
+apr_status_t h2_conn_process(struct h2_ctx *ctx, int async);
 
 /**
- * Run the HTTP/2 connection. Return when the HTTP/2 session is done
+ * Run the HTTP/2 connection in synchronous fashion. 
+ * Return when the HTTP/2 session is done
  * and the connection will close or a fatal error occured.
  *
  * @param ctx the http2 context to run
  * @return APR_SUCCESS when session is done.
  */
-apr_status_t h2_conn_run(struct h2_ctx *ctx);
+apr_status_t h2_conn_run(struct h2_ctx *ctx, conn_rec *c);
 
 /* Initialize this child process for h2 connection work,
  * to be called once during child init before multi processing

diff --git a/modules/http2/h2_ctx.c b/modules/http2/h2_ctx.c
index bf8dab20c9bd815a68ba75551b641eb25c1f0e77..fa0a3c8e94ebf0b04792d0615ba312ac4cf2e7a8 100644 (file)
--- a/modules/http2/h2_ctx.c
+++ b/modules/http2/h2_ctx.c
@@ -34,6 +34,12 @@ static h2_ctx *h2_ctx_create(const conn_rec *c)
     return ctx;
 }
 
+void h2_ctx_clear(const conn_rec *c)
+{
+    AP_DEBUG_ASSERT(c);
+    ap_set_module_config(c->conn_config, &http2_module, NULL);
+}
+
 h2_ctx *h2_ctx_create_for(const conn_rec *c, h2_task *task)
 {
     h2_ctx *ctx = h2_ctx_create(c);

diff --git a/modules/http2/h2_ctx.h b/modules/http2/h2_ctx.h
index 4f85ddcdf4961cf75f55782fd8df2c9890c1b992..68dc7c84c350b43af7883c218f55452b35ec6469 100644 (file)
--- a/modules/http2/h2_ctx.h
+++ b/modules/http2/h2_ctx.h
@@ -44,6 +44,7 @@ typedef struct h2_ctx {
  * @return h2 context of this connection
  */
 h2_ctx *h2_ctx_get(const conn_rec *c, int create);
+void h2_ctx_clear(const conn_rec *c);
 
 h2_ctx *h2_ctx_rget(const request_rec *r);
 h2_ctx *h2_ctx_create_for(const conn_rec *c, struct h2_task *task);

diff --git a/modules/http2/h2_h2.c b/modules/http2/h2_h2.c
index 353a9e6c01d0a367ae6f898756895bcaa26f3567..1a7e284c00a3feaccc6ae2e3682237207cbe7626 100644 (file)
--- a/modules/http2/h2_h2.c
+++ b/modules/http2/h2_h2.c
@@ -637,12 +637,17 @@ int h2_h2_process_conn(conn_rec* c)
         ap_log_cerror(APLOG_MARK, APLOG_TRACE1, 0, c, "process_conn");
         if (!h2_ctx_session_get(ctx)) {
             status = h2_conn_setup(ctx, c, NULL);
+            ap_log_cerror(APLOG_MARK, APLOG_TRACE1, status, c, "conn_setup");
             if (status != APR_SUCCESS) {
-                ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, c, "conn_setup");
                 return status;
             }
         }
-        return h2_conn_process(ctx);
+        if (h2_config_async_mpm()) {
+            return h2_conn_process(ctx, 1);
+        }
+        else {
+            return h2_conn_run(ctx, c);
+        }
     }
     
     ap_log_cerror(APLOG_MARK, APLOG_TRACE1, 0, c, "h2_h2, declined");

diff --git a/modules/http2/h2_session.c b/modules/http2/h2_session.c
index 5ed4e4267a4b03ed6f434314408e0f289897b78e..c4d31ab14768a6db7e7910093d91803f0f9ad3bb 100644 (file)
--- a/modules/http2/h2_session.c
+++ b/modules/http2/h2_session.c
@@ -26,6 +26,7 @@
 #include "h2_private.h"
 #include "h2_bucket_eos.h"
 #include "h2_config.h"
+#include "h2_ctx.h"
 #include "h2_h2.h"
 #include "h2_mplx.h"
 #include "h2_push.h"
@@ -586,9 +587,11 @@ static int on_frame_send_cb(nghttp2_session *ngh2,
         
         frame_print(frame, buffer, sizeof(buffer)/sizeof(buffer[0]));
         ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c,
-                      "h2_session(%ld): frame_send %s",
-                      session->id, buffer);
+                      "h2_session(%ld): send %s, frames=%ld/%ld (r/s)",
+                      session->id, buffer, (long)session->frames_received,
+                     (long)session->frames_sent);
     }
+    ++session->frames_sent;
     return 0;
 }
 
@@ -621,7 +624,15 @@ static apr_status_t init_callbacks(conn_rec *c, nghttp2_session_callbacks **pcb)
 static apr_status_t session_pool_cleanup(void *data)
 {
     h2_session *session = data;
-    
+    /* On a controlled connection shutdown, this gets never
+     * called as we deregister and destroy our pool manually.
+     * However when we have an async mpm, and handed it our idle
+     * connection, it will just cleanup once the connection is closed
+     * from the other side (and sometimes even from out side) and
+     * here we arrive then.
+     */
+    ap_log_cerror(APLOG_MARK, APLOG_TRACE1, 0, session->c,
+                  "session(%ld): pool_cleanup", session->id);
     /* keep us from destroying the pool, since that is already ongoing. */
     session->pool = NULL;
     h2_session_destroy(session);
@@ -668,7 +679,7 @@ static void *session_realloc(void *p, size_t size, void *ctx)
 
 static h2_session *h2_session_create_int(conn_rec *c,
                                          request_rec *r,
-                                         const h2_config *config, 
+                                         h2_ctx *ctx, 
                                          h2_workers *workers)
 {
     nghttp2_session_callbacks *callbacks = NULL;
@@ -689,13 +700,14 @@ static h2_session *h2_session_create_int(conn_rec *c,
         session->id = c->id;
         session->c = c;
         session->r = r;
-        session->config = config;
+        session->s = h2_ctx_server_get(ctx);
+        session->config = h2_config_sget(session->s);
         
         session->pool = pool;
         apr_pool_pre_cleanup_register(pool, session, session_pool_cleanup);
         
-        session->max_stream_count = h2_config_geti(config, H2_CONF_MAX_STREAMS);
-        session->max_stream_mem = h2_config_geti(config, H2_CONF_STREAM_MAX_MEM);
+        session->max_stream_count = h2_config_geti(session->config, H2_CONF_MAX_STREAMS);
+        session->max_stream_mem = h2_config_geti(session->config, H2_CONF_STREAM_MAX_MEM);
 
         status = apr_thread_cond_create(&session->iowait, session->pool);
         if (status != APR_SUCCESS) {
@@ -705,11 +717,11 @@ static h2_session *h2_session_create_int(conn_rec *c,
         session->streams = h2_stream_set_create(session->pool, session->max_stream_count);
         
         session->workers = workers;
-        session->mplx = h2_mplx_create(c, session->pool, config, workers);
+        session->mplx = h2_mplx_create(c, session->pool, session->config, workers);
         
         h2_mplx_set_consumed_cb(session->mplx, update_window, session);
         
-        h2_conn_io_init(&session->io, c, config, session->pool);
+        h2_conn_io_init(&session->io, c, session->config, session->pool);
         session->bbtmp = apr_brigade_create(session->pool, c->bucket_alloc);
         
         status = init_callbacks(c, &callbacks);
@@ -764,16 +776,14 @@ static h2_session *h2_session_create_int(conn_rec *c,
     return session;
 }
 
-h2_session *h2_session_create(conn_rec *c, const h2_config *config, 
-                              h2_workers *workers)
+h2_session *h2_session_create(conn_rec *c, h2_ctx *ctx, h2_workers *workers)
 {
-    return h2_session_create_int(c, NULL, config, workers);
+    return h2_session_create_int(c, NULL, ctx, workers);
 }
 
-h2_session *h2_session_rcreate(request_rec *r, const h2_config *config, 
-                               h2_workers *workers)
+h2_session *h2_session_rcreate(request_rec *r, h2_ctx *ctx, h2_workers *workers)
 {
-    return h2_session_create_int(r->connection, r, config, workers);
+    return h2_session_create_int(r->connection, r, ctx, workers);
 }
 
 static void h2_session_cleanup(h2_session *session)
@@ -786,6 +796,9 @@ static void h2_session_cleanup(h2_session *session)
      * our buffers or passed down output filters.
      * h2 streams might still being written out.
      */
+    if (session->c) {
+        h2_ctx_clear(session->c);
+    }
     if (session->ngh2) {
         nghttp2_session_del(session->ngh2);
         session->ngh2 = NULL;
@@ -800,17 +813,17 @@ void h2_session_destroy(h2_session *session)
 {
     AP_DEBUG_ASSERT(session);
     h2_session_cleanup(session);
-    
+
+    if (APLOGctrace1(session->c)) {
+        ap_log_cerror(APLOG_MARK, APLOG_TRACE1, 0, session->c,
+                      "h2_session(%ld): destroy, %d streams open",
+                      session->id, (int)h2_stream_set_size(session->streams));
+    }
     if (session->mplx) {
         h2_mplx_release_and_join(session->mplx, session->iowait);
         session->mplx = NULL;
     }
     if (session->streams) {
-        if (!h2_stream_set_is_empty(session->streams)) {
-            ap_log_cerror(APLOG_MARK, APLOG_TRACE2, 0, session->c,
-                          "h2_session(%ld): destroy, %d streams open",
-                          session->id, (int)h2_stream_set_size(session->streams));
-        }
         h2_stream_set_destroy(session->streams);
         session->streams = NULL;
     }
@@ -894,7 +907,7 @@ apr_status_t h2_session_abort(h2_session *session, apr_status_t reason, int rv)
     return h2_session_abort_int(session, rv);
 }
 
-apr_status_t h2_session_start(h2_session *session, int *rv)
+static apr_status_t h2_session_start(h2_session *session, int *rv)
 {
     apr_status_t status = APR_SUCCESS;
     nghttp2_settings_entry settings[3];
@@ -1555,216 +1568,268 @@ int h2_session_push_enabled(h2_session *session)
                                                NGHTTP2_SETTINGS_ENABLE_PUSH);
 }
 
+static apr_status_t h2_session_send(h2_session *session)
+{
+    int rv = nghttp2_session_send(session->ngh2);
+    if (rv != 0) {
+        ap_log_cerror( APLOG_MARK, APLOG_DEBUG, 0, session->c,
+                      "h2_session: send: %s", nghttp2_strerror(rv));
+        if (nghttp2_is_fatal(rv)) {
+            h2_session_abort_int(session, rv);
+            return APR_EGENERAL;
+        }
+    }
+    
+    session->wait_micros = 0;
+    session->unsent_promises = 0;
+    session->unsent_submits = 0;
+    
+    return APR_SUCCESS;
+}
 
-apr_status_t h2_session_process(h2_session *session)
+static apr_status_t h2_session_read(h2_session *session, int block)
 {
-    apr_status_t status = APR_SUCCESS;
-    apr_interval_time_t wait_micros = 0;
-    static const int MAX_WAIT_MICROS = 200 * 1000;
-    int got_streams = 0;
-    h2_stream *stream;
+    apr_status_t status;
+    
+    status = h2_conn_io_read(&session->io, 
+                             block? APR_BLOCK_READ : APR_NONBLOCK_READ, 
+                             session_receive, session);
+    switch (status) {
+        case APR_SUCCESS:
+            /* successful read, reset our idle timers */
+            session->wait_micros = 0;
+            break;
+        case APR_EAGAIN:
+            break;
+        default:
+            if (APR_STATUS_IS_ETIMEDOUT(status)
+                || APR_STATUS_IS_ECONNABORTED(status)
+                || APR_STATUS_IS_ECONNRESET(status)
+                || APR_STATUS_IS_EOF(status)
+                || APR_STATUS_IS_EBADF(status)) {
+                /* common status for a client that has left */
+                ap_log_cerror( APLOG_MARK, APLOG_DEBUG, status, session->c,
+                              "h2_session(%ld): terminating",
+                              session->id);
+                /* Stolen from mod_reqtimeout to speed up lingering when
+                 * a read timeout happened.
+                 */
+                apr_table_setn(session->c->notes, "short-lingering-close", "1");
+            }
+            else {
+                /* uncommon status, log on INFO so that we see this */
+                ap_log_cerror( APLOG_MARK, APLOG_INFO, status, session->c,
+                              APLOGNO(02950) 
+                              "h2_session(%ld): error reading, terminating",
+                              session->id);
+            }
+            h2_session_abort(session, status, 0);
+            break;
+    }
+    return status;
+}
 
-    while (!session->aborted && (nghttp2_session_want_read(session->ngh2)
-                                 || nghttp2_session_want_write(session->ngh2))) {
-        int have_written = 0;
-        int have_read = 0;
-                                 
-        got_streams = !h2_stream_set_is_empty(session->streams);
-        if (got_streams) {            
-            h2_session_resume_streams_with_data(session);
+static apr_status_t h2_session_submit(h2_session *session)
+{
+    apr_status_t status = APR_EAGAIN;
+    h2_stream *stream;
+    
+    if (h2_stream_set_has_unsubmitted(session->streams)) {
+        /* If we have responses ready, submit them now. */
+        while ((stream = h2_mplx_next_submit(session->mplx, session->streams))) {
+            status = submit_response(session, stream);
+            ++session->unsent_submits;
             
-            if (h2_stream_set_has_unsubmitted(session->streams)) {
-                int unsent_submits = 0;
-                
-                /* If we have responses ready, submit them now. */
-                while ((stream = h2_mplx_next_submit(session->mplx, session->streams))) {
-                    status = submit_response(session, stream);
-                    ++unsent_submits;
-                    
-                    /* Unsent push promises are written immediately, as nghttp2
-                     * 1.5.0 realizes internal stream data structures only on 
-                     * send and we might need them for other submits. 
-                     * Also, to conserve memory, we send at least every 10 submits
-                     * so that nghttp2 does not buffer all outbound items too 
-                     * long.
-                     */
-                    if (status == APR_SUCCESS 
-                        && (session->unsent_promises || unsent_submits > 10)) {
-                        int rv = nghttp2_session_send(session->ngh2);
-                        if (rv != 0) {
-                            ap_log_cerror( APLOG_MARK, APLOG_DEBUG, 0, session->c,
-                                          "h2_session: send: %s", nghttp2_strerror(rv));
-                            if (nghttp2_is_fatal(rv)) {
-                                h2_session_abort(session, status, rv);
-                                status = APR_EGENERAL;
-                                goto end_process;
-                            }
-                        }
-                        else {
-                            have_written = 1;
-                            wait_micros = 0;
-                            session->unsent_promises = 0;
-                            unsent_submits = 0;
-                        }
-                    }
+            /* Unsent push promises are written immediately, as nghttp2
+             * 1.5.0 realizes internal stream data structures only on 
+             * send and we might need them for other submits. 
+             * Also, to conserve memory, we send at least every 10 submits
+             * so that nghttp2 does not buffer all outbound items too 
+             * long.
+             */
+            if (status == APR_SUCCESS 
+                && (session->unsent_promises || session->unsent_submits > 10)) {
+                status = h2_session_send(session);
+                if (status != APR_SUCCESS) {
+                    break;
                 }
             }
         }
-        
-        /* Send data as long as we have it and window sizes allow. We are
-         * a server after all.
-         */
-        if (nghttp2_session_want_write(session->ngh2)) {
+    }
+    return status;
+}
+
+static const int MAX_WAIT_MICROS = 200 * 1000;
+
+apr_status_t h2_session_process(h2_session *session, int async)
+{
+    apr_status_t status = APR_SUCCESS;
+    int got_streams = 0;
+    int have_written = 0;
+    int have_read = 0;
+
+    ap_log_cerror( APLOG_MARK, APLOG_TRACE1, status, session->c,
+                  "h2_session(%ld): process", session->id);
+
+    while (1) {
+        if (session->aborted || (!nghttp2_session_want_read(session->ngh2)
+                                 && !nghttp2_session_want_write(session->ngh2))) {
+            ap_log_cerror( APLOG_MARK, APLOG_DEBUG, status, session->c,
+                          "h2_session(%ld): process -> aborted", session->id);
+            h2_conn_io_flush(&session->io);
+            return APR_EOF;
+        }
+
+        if (!session->started) {
             int rv;
             
-            rv = nghttp2_session_send(session->ngh2);
-            if (rv != 0) {
-                ap_log_cerror( APLOG_MARK, APLOG_DEBUG, 0, session->c,
-                              "h2_session: send: %s", nghttp2_strerror(rv));
-                if (nghttp2_is_fatal(rv)) {
-                    h2_session_abort(session, status, rv);
-                    status = APR_EGENERAL;
-                    goto end_process;
-                }
-            }
-            else {
-                have_written = 1;
-                wait_micros = 0;
-                session->unsent_promises = 0;
+            if (!h2_is_acceptable_connection(session->c, 1)) {
+                nghttp2_submit_goaway(session->ngh2, NGHTTP2_FLAG_NONE, 0,
+                                      NGHTTP2_INADEQUATE_SECURITY, NULL, 0);
+            } 
+            
+            status = h2_session_start(session, &rv);
+            ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, session->c,
+                          "h2_session(%ld): starting on %s:%d", session->id,
+                          session->s->server_hostname,
+                          session->c->local_addr->port);
+            if (status != APR_SUCCESS) {
+                h2_session_abort(session, status, rv);
+                h2_session_eoc_callback(session);
             }
+            session->started = 1;
         }
         
-        if (wait_micros > 0) {
-            if (APLOGcdebug(session->c)) {
-                ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c,
-                              "h2_session: wait for data, %ld micros", 
-                              (long)wait_micros);
+        got_streams = !h2_stream_set_is_empty(session->streams);
+        if (got_streams) {
+            ap_log_cerror( APLOG_MARK, APLOG_TRACE2, status, session->c,
+                          "h2_session(%ld): process -> check resume", session->id);
+            /* resume any streams for which data is available again */
+            h2_session_resume_streams_with_data(session);
+            
+            /* Submit any responses/push_promises that are ready */
+            ap_log_cerror( APLOG_MARK, APLOG_TRACE2, status, session->c,
+                          "h2_session(%ld): process -> check submit", session->id);
+            status = h2_session_submit(session);
+            if (status == APR_SUCCESS) {
+                have_written = 1;
+            }
+            else if (status != APR_EAGAIN) {
+                return status;
             }
-            nghttp2_session_send(session->ngh2);
-            h2_conn_io_flush(&session->io);
-            status = h2_mplx_out_trywait(session->mplx, wait_micros, session->iowait);
             
-            if (status == APR_TIMEUP) {
-                if (wait_micros < MAX_WAIT_MICROS) {
-                    wait_micros *= 2;
-                }
+            /* Check that any pending window updates are sent. */
+            ap_log_cerror( APLOG_MARK, APLOG_TRACE2, status, session->c,
+                          "h2_session(%ld): process -> check window_update", session->id);
+            status = h2_mplx_in_update_windows(session->mplx);
+            if (status == APR_SUCCESS) {
+                /* need to flush window updates onto the connection asap */
+                h2_conn_io_flush(&session->io);
+            }
+            else if (status != APR_EAGAIN) {
+                return status;
             }
         }
         
-        if (nghttp2_session_want_read(session->ngh2))
-        {
-            /* When we
-             * - and have no streams at all
-             * - or have streams, but none is suspended or needs submit and
-             *   have nothing written on the last try
-             * 
-             * or, the other way around
-             * - have only streams where data can be sent, but could
-             *   not send anything
-             *
-             * then we are waiting on frames from the client (for
-             * example WINDOW_UPDATE or HEADER) and without new frames
-             * from the client, we cannot make any progress,
-             * 
-             * and *then* we can safely do a blocking read.
-             */
-            int may_block = (session->frames_received <= 1);
-            if (!may_block) {
-                if (got_streams) {
-                    may_block = (!have_written 
-                                 && !h2_stream_set_has_unsubmitted(session->streams)
-                                 && !h2_stream_set_has_suspended(session->streams));
-                }
-                else {
-                    may_block = 1;
-                }
+        /* Send data out first, as long as we have some. 
+         * We are a server after all. */
+        if (nghttp2_session_want_write(session->ngh2)) {
+            status = h2_session_send(session);
+            ap_log_cerror( APLOG_MARK, APLOG_TRACE1, status, session->c,
+                          "h2_session(%ld): process -> send", session->id);
+            have_written = 1;
+            if (status != APR_SUCCESS) {
+                ap_log_cerror( APLOG_MARK, APLOG_DEBUG, status, session->c,
+                              "h2_session(%ld): failed send", session->id);
+                return status;
             }
+        }
+        
+        /* If we want client data, see if some is there. */
+        if (nghttp2_session_want_read(session->ngh2)) {
+            int idle      = (session->frames_received > 2 && !got_streams);
+            int may_block = ((session->frames_received <= 1) 
+                             || (idle && !async)
+                             || (!have_written && !h2_stream_set_has_unsubmitted(session->streams)
+                                 && !h2_stream_set_has_suspended(session->streams)));
+            status = h2_session_read(session, may_block);
             
-            if (may_block) {
-                h2_conn_io_flush(&session->io);
-                if (session->c->cs) {
-                    session->c->cs->state = (got_streams? CONN_STATE_HANDLER
-                                             : CONN_STATE_WRITE_COMPLETION);
+            ap_log_cerror( APLOG_MARK, APLOG_TRACE1, status, session->c,
+                          "h2_session(%ld): process -> read", session->id);
+            if (status == APR_SUCCESS) {
+                have_read = 1;
+                got_streams = !h2_stream_set_is_empty(session->streams);
+                if (session->reprioritize) {
+                    ap_log_cerror( APLOG_MARK, APLOG_TRACE2, status, session->c,
+                                  "h2_session(%ld): process -> reprioritize", session->id);
+                    h2_mplx_reprioritize(session->mplx, stream_pri_cmp, session);
+                    session->reprioritize = 0;
                 }
-                status = h2_conn_io_read(&session->io, APR_BLOCK_READ, 
-                                         session_receive, session);
             }
-            else {
+            else if (status == APR_EAGAIN && idle && async) {
+                /* There is nothing to read and we are in a state where we
+                 * have nothing to write until new input comes. Return to
+                 * our caller so that the MPM may schedule us again when
+                 * read seems possible.
+                 */
+                ap_log_cerror( APLOG_MARK, APLOG_TRACE1, status, session->c,
+                              "h2_session(%ld): process -> BLOCK_READ, "
+                              "frames_received=%d, got_streams=%d, "
+                              "have_written=%d", 
+                              session->id, (int)session->frames_received,
+                              (int)got_streams, (int)have_written);
+                if (have_written) {
+                    h2_conn_io_flush(&session->io);
+                }
                 if (session->c->cs) {
-                    session->c->cs->state = CONN_STATE_HANDLER;
+                    session->c->cs->state = CONN_STATE_WRITE_COMPLETION;
+                    session->c->cs->sense = (have_written? 
+                                             CONN_SENSE_DEFAULT
+                                             : CONN_SENSE_WANT_READ);
                 }
-                status = h2_conn_io_read(&session->io, APR_NONBLOCK_READ, 
-                                         session_receive, session);
+                return APR_SUCCESS;
             }
-
-            switch (status) {
-                case APR_SUCCESS:       /* successful read, reset our idle timers */
-                    have_read = 1;
-                    wait_micros = 0;
-                    break;
-                case APR_EAGAIN:              /* non-blocking read, nothing there */
-                    break;
-                default:
-                    if (APR_STATUS_IS_ETIMEDOUT(status)
-                        || APR_STATUS_IS_ECONNABORTED(status)
-                        || APR_STATUS_IS_ECONNRESET(status)
-                        || APR_STATUS_IS_EOF(status)
-                        || APR_STATUS_IS_EBADF(status)) {
-                        /* common status for a client that has left */
-                        ap_log_cerror( APLOG_MARK, APLOG_DEBUG, status, session->c,
-                                      "h2_session(%ld): terminating",
-                                      session->id);
-                        /* Stolen from mod_reqtimeout to speed up lingering when
-                         * a read timeout happened.
-                         */
-                        apr_table_setn(session->c->notes, "short-lingering-close", "1");
-                    }
-                    else {
-                        /* uncommon status, log on INFO so that we see this */
-                        ap_log_cerror( APLOG_MARK, APLOG_INFO, status, session->c,
-                                      APLOGNO(02950) 
-                                      "h2_session(%ld): error reading, terminating",
-                                      session->id);
-                    }
-                    h2_session_abort(session, status, 0);
-                    goto end_process;
+        }
+            
+        if (!have_read && !have_written) {
+            if (session->wait_micros == 0) {
+                session->wait_micros = 10;
             }
         }
         
-        got_streams = !h2_stream_set_is_empty(session->streams);
-        if (got_streams) {            
-            if (session->reprioritize) {
-                h2_mplx_reprioritize(session->mplx, stream_pri_cmp, session);
-                session->reprioritize = 0;
+        if (session->wait_micros > 0 && !session->aborted) {
+            /* Only happens when reading returned EAGAIN and we also
+             * had nothing to write. 
+             * This is a normal state of affairs when streams have been
+             * opened, the client waiting on responses, but our workers
+             * have not produced anything to send yet.
+             */
+            if (APLOGcdebug(session->c)) {
+                ap_log_cerror(APLOG_MARK, APLOG_TRACE1, 0, session->c,
+                              "h2_session: wait for data, %ld micros", 
+                              (long)session->wait_micros);
             }
             
-            if (!have_read && !have_written) {
-                /* Nothing read or written. That means no data yet ready to 
-                 * be send out. Slowly back off...
-                 */
-                if (wait_micros == 0) {
-                    wait_micros = 10;
+            h2_conn_io_flush(&session->io);
+            ap_log_cerror( APLOG_MARK, APLOG_TRACE2, status, session->c,
+                          "h2_session(%ld): process -> trywait", session->id);
+            status = h2_mplx_out_trywait(session->mplx, session->wait_micros, 
+                                         session->iowait);
+            if (status == APR_TIMEUP) {
+                if (session->wait_micros < MAX_WAIT_MICROS) {
+                    session->wait_micros *= 2;
                 }
             }
-            
-            /* Check that any pending window updates are sent. */
-            status = h2_mplx_in_update_windows(session->mplx);
-            if (APR_STATUS_IS_EAGAIN(status)) {
-                status = APR_SUCCESS;
-            }
-            else if (status == APR_SUCCESS) {
-                /* need to flush window updates onto the connection asap */
-                h2_conn_io_flush(&session->io);
-            }
         }
         
         if (have_written) {
             h2_conn_io_flush(&session->io);
         }
+        have_written = 0;
+        have_read = 0;
     }
-    /* normal end of session */
-    status = APR_EOF;
-    
-end_process:
+        
+    ap_log_cerror( APLOG_MARK, APLOG_TRACE1, status, session->c,
+                  "h2_session(%ld): process -> return", session->id);
     return status;
 }

diff --git a/modules/http2/h2_session.h b/modules/http2/h2_session.h
index cc2608089ac1a55c22f86bb981771cd4d4a05c15..2b459ea677c6c73fb20f678d56aa630721ffab06 100644 (file)
--- a/modules/http2/h2_session.h
+++ b/modules/http2/h2_session.h
@@ -39,6 +39,7 @@
 
 struct apr_thread_mutext_t;
 struct apr_thread_cond_t;
+struct h2_ctx;
 struct h2_config;
 struct h2_mplx;
 struct h2_priority;
@@ -59,13 +60,21 @@ struct h2_session {
     conn_rec *c;                    /* the connection this session serves */
     request_rec *r;                 /* the request that started this in case
                                      * of 'h2c', NULL otherwise */
+    server_rec *s;                  /* server/vhost we're starting on */
     const struct h2_config *config; /* Relevant config for this session */
+    int started;
     int aborted;                    /* this session is being aborted */
     int reprioritize;               /* scheduled streams priority needs to 
                                      * be re-evaluated */
+                                     
+    apr_interval_time_t  wait_micros;
+    int unsent_submits;             /* number of submitted, but not yet sent
+                                       responses. */
     int unsent_promises;            /* number of submitted, but not yet sent
                                      * push promised */
+                                     
     apr_size_t frames_received;     /* number of http/2 frames received */
+    apr_size_t frames_sent;         /* number of http/2 frames sent */
     apr_size_t max_stream_count;    /* max number of open streams */
     apr_size_t max_stream_mem;      /* max buffer memory for a single stream */
     
@@ -97,7 +106,7 @@ struct h2_session {
  * @param workers the worker pool to use
  * @return the created session
  */
-h2_session *h2_session_create(conn_rec *c, const struct h2_config *cfg, 
+h2_session *h2_session_create(conn_rec *c, struct h2_ctx *ctx, 
                               struct h2_workers *workers);
 
 /**
@@ -108,7 +117,7 @@ h2_session *h2_session_create(conn_rec *c, const struct h2_config *cfg,
  * @param workers the worker pool to use
  * @return the created session
  */
-h2_session *h2_session_rcreate(request_rec *r, const struct h2_config *cfg,
+h2_session *h2_session_rcreate(request_rec *r, struct h2_ctx *ctx,
                                struct h2_workers *workers);
 
 /**
@@ -117,7 +126,7 @@ h2_session *h2_session_rcreate(request_rec *r, const struct h2_config *cfg,
  *
  * @param session the sessionm to process
  */
-apr_status_t h2_session_process(h2_session *session);
+apr_status_t h2_session_process(h2_session *session, int async);
 
 /**
  * Destroy the session and all objects it still contains. This will not
@@ -133,15 +142,6 @@ void h2_session_destroy(h2_session *session);
  */
 void h2_session_eoc_callback(h2_session *session);
 
-/**
- * Called once at start of session. 
- * Sets up the session and sends the initial SETTINGS frame.
- * @param session the session to start
- * @param rv error codes in libnghttp2 lingo are returned here
- * @return APR_SUCCESS if all went well
- */
-apr_status_t h2_session_start(h2_session *session, int *rv);
-
 /**
  * Called when an error occured and the session needs to shut down.
  * @param session the session to shut down

diff --git a/modules/http2/h2_switch.c b/modules/http2/h2_switch.c
index bc41b6149fe46c844534176ada5b38c95305913d..3b1789a9afaf9ba9da808a2ec465f4a00f786ea7 100644 (file)
--- a/modules/http2/h2_switch.c
+++ b/modules/http2/h2_switch.c
@@ -163,7 +163,7 @@ static int h2_protocol_switch(conn_rec *c, request_rec *r, server_rec *s,
                 return status;
             }
             
-            return h2_conn_run(ctx);
+            return h2_conn_run(ctx, c);
         }
         return DONE;
     }