Add C comment about why older compilers complain about basebackup.c's

longjump.

diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c
index b5cda5063be570a89e2dbbc7fc6bc3a7bc1e5178..d94b61f23ef57ea1d0e9481e592fc38d553a7b7b 100644 (file)
--- a/src/backend/replication/basebackup.c
+++ b/src/backend/replication/basebackup.c
@@ -217,6 +217,12 @@ perform_base_backup(basebackup_options *opt, DIR *tblspcdir)
                                ptr.xlogid = logid;
                                ptr.xrecoff = logseg * XLogSegSize + TAR_SEND_SIZE * i;
 
+                               /*
+                                *      Some old compilers, e.g. 2.95.3/x86, think that passing
+                                *      a struct in the same function as a longjump might clobber
+                                *      a variable.  bjm 2011-02-04
+                                *      http://lists.apple.com/archives/xcode-users/2003/Dec//msg00051.html
+                                */
                                XLogRead(buf, ptr, TAR_SEND_SIZE);
                                if (pq_putmessage('d', buf, TAR_SEND_SIZE))
                                        ereport(ERROR,