]> granicus.if.org Git - python/commitdiff
Merged revisions 86209 via svnmerge from
authorBrian Curtin <brian.curtin@gmail.com>
Fri, 5 Nov 2010 17:24:20 +0000 (17:24 +0000)
committerBrian Curtin <brian.curtin@gmail.com>
Fri, 5 Nov 2010 17:24:20 +0000 (17:24 +0000)
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86209 | brian.curtin | 2010-11-05 12:22:46 -0500 (Fri, 05 Nov 2010) | 2 lines

  Close subprocess pipes to clean up ResourceWarnings
........

Lib/test/test_threading.py

index 21b7a04e2d08dd0902a88608e4c86958eaa0c24b..a06415de588a36ba6011a38d43fa4310ecd0dc8b 100644 (file)
@@ -330,6 +330,8 @@ class ThreadTests(BaseTestCase):
             """],
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE)
+        self.addCleanup(p.stdout.close)
+        self.addCleanup(p.stderr.close)
         stdout, stderr = p.communicate()
         rc = p.returncode
         self.assertFalse(rc == 2, "interpreted was blocked")
@@ -355,6 +357,8 @@ class ThreadTests(BaseTestCase):
             """],
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE)
+        self.addCleanup(p.stdout.close)
+        self.addCleanup(p.stderr.close)
         stdout, stderr = p.communicate()
         self.assertEqual(stdout.strip(),
             "Woke up, sleep function is: <built-in function sleep>")