]> granicus.if.org Git - php/commitdiff
Fix bug #64729: compilation failure on x32
authorGustavo Lopes <glopes@nebm.ist.utl.pt>
Tue, 30 Apr 2013 17:00:31 +0000 (19:00 +0200)
committerGustavo Lopes <glopes@nebm.ist.utl.pt>
Tue, 30 Apr 2013 17:28:24 +0000 (19:28 +0200)
Zend/zend_alloc.c
Zend/zend_multiply.h

index 605e39646367a184c1810aa582437b6d675ee7bd..0bbd59a357c446206410a200c4cb93c7e4225371 100644 (file)
@@ -672,7 +672,7 @@ static inline unsigned int zend_mm_high_bit(size_t _size)
 #elif defined(__GNUC__) && defined(__x86_64__)
        unsigned long n;
 
-        __asm__("bsrq %1,%0\n\t" : "=r" (n) : "rm"  (_size));
+        __asm__("bsr %1,%0\n\t" : "=r" (n) : "rm"  (_size));
         return (unsigned int)n;
 #elif defined(_MSC_VER) && defined(_M_IX86)
        __asm {
@@ -698,12 +698,12 @@ static inline unsigned int zend_mm_low_bit(size_t _size)
 #elif defined(__GNUC__) && defined(__x86_64__)
         unsigned long n;
 
-        __asm__("bsfq %1,%0\n\t" : "=r" (n) : "rm"  (_size));
+        __asm__("bsf %1,%0\n\t" : "=r" (n) : "rm"  (_size));
         return (unsigned int)n;
 #elif defined(_MSC_VER) && defined(_M_IX86)
        __asm {
                bsf eax, _size
-   }
+       }
 #else
        static const int offset[16] = {4,0,1,0,2,0,1,0,3,0,1,0,2,0,1,0};
        unsigned int n;
@@ -2481,12 +2481,22 @@ static inline size_t safe_address(size_t nmemb, size_t size, size_t offset)
         size_t res = nmemb;
         unsigned long overflow = 0;
 
-        __asm__ ("mulq %3\n\taddq %4,%0\n\tadcq %1,%1"
+#ifdef __ILP32__ /* x32 */
+# define LP_SUFF "l"
+#else /* amd64 */
+# define LP_SUFF "q"
+#endif
+
+        __asm__ ("mul" LP_SUFF  " %3\n\t"
+                 "add %4,%0\n\t"
+                 "adc %1,%1"
              : "=&a"(res), "=&d" (overflow)
              : "%0"(res),
                "rm"(size),
                "rm"(offset));
 
+#undef LP_SUFF
+
         if (UNEXPECTED(overflow)) {
                 zend_error_noreturn(E_ERROR, "Possible integer overflow in memory allocation (%zu * %zu + %zu)", nmemb, size, offset);
                 return 0;
index c3c9657f3b25e987d43748bdb96327c244012d3f..092d3cd0b279a4488cf419891d990bd36c5a9202 100644 (file)
@@ -35,8 +35,8 @@
 
 #define ZEND_SIGNED_MULTIPLY_LONG(a, b, lval, dval, usedval) do {      \
        long __tmpvar;                                                                                                  \
-       __asm__ ("imulq %3,%0\n"                                                                                \
-               "adcq $0,%1"                                                                                            \
+       __asm__ ("imul %3,%0\n"                                                                                 \
+               "adc $0,%1"                                                                                             \
                        : "=r"(__tmpvar),"=r"(usedval)                                                  \
                        : "0"(a), "r"(b), "1"(0));                                                              \
        if (usedval) (dval) = (double) (a) * (double) (b);                              \