]> granicus.if.org Git - icu/commitdiff
ICU-21959 Update stale Jira tickets in ICU4J TODOs
authorHugo van der Merwe <17109322+hugovdm@users.noreply.github.com>
Sat, 9 Apr 2022 20:27:59 +0000 (20:27 +0000)
committerHugo van der Merwe <17109322+hugovdm@users.noreply.github.com>
Wed, 27 Apr 2022 21:31:46 +0000 (23:31 +0200)
See #2062

icu4j/main/classes/core/src/com/ibm/icu/impl/units/UnitsConverter.java
icu4j/main/tests/core/src/com/ibm/icu/dev/test/impl/UnitsTest.java
icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java

index 156a6e0b6db69ea777d110e63898c611b969b157..fba34528f3f846b178d57347c0d7ebbb721c1401 100644 (file)
@@ -116,7 +116,7 @@ public class UnitsConverter {
             // We should see no offsets for reciprocal conversions - they don't make sense:
             assert offset == BigDecimal.ZERO;
             if (result.compareTo(BigDecimal.ZERO) == 0) {
-                // TODO(ICU-21862): determine desirable behaviour
+                // TODO(ICU-21988): determine desirable behaviour
                 return BigDecimal.ZERO;
             }
             result = BigDecimal.ONE.divide(result, DECIMAL128);
@@ -130,7 +130,7 @@ public class UnitsConverter {
             // We should see no offsets for reciprocal conversions - they don't make sense:
             assert offset == BigDecimal.ZERO;
             if (result.compareTo(BigDecimal.ZERO) == 0) {
-                // TODO(ICU-21862): determine desirable behaviour
+                // TODO(ICU-21988): determine desirable behaviour
                 return BigDecimal.ZERO;
             }
             result = BigDecimal.ONE.divide(result, DECIMAL128);
index 6bfd1a71970114d54ed998e1c944e9aafe2322cb..f7713dd1b0bf6165997e8b0bae78abaeecd8d4e1 100644 (file)
@@ -472,10 +472,10 @@ public class UnitsTest {
                 new TestData("cubic-meter-per-meter", "mile-per-gallon", 2.1383143939394E-6, 1.1),
                 new TestData("cubic-meter-per-meter", "mile-per-gallon", 2.6134953703704E-6, 0.9),
                 new TestData("liter-per-100-kilometer", "mile-per-gallon", 6.6, 35.6386),
-                // // TODO(ICU-21862): we should probably return something other than "0":
+                // // TODO(ICU-21988): we should probably return something other than "0":
                 // new TestData("liter-per-100-kilometer", "mile-per-gallon", 0, 0),
                 // new TestData("mile-per-gallon", "liter-per-100-kilometer", 0, 0),
-                // // TODO(ICU-21862): deal with infinity input in Java?
+                // // TODO(ICU-21988): deal with infinity input in Java?
                 // new TestData("mile-per-gallon", "liter-per-100-kilometer", INFINITY, 0),
                 // We skip testing -Inf, because the inverse conversion loses the sign:
                 // new TestData("mile-per-gallon", "liter-per-100-kilometer", -INFINITY, 0),
index e4a8e9d53dbd2839a7ccdc02e186f10404c33bdf..1430dab40f819d95dac80a34f7a26b14196f4d9c 100644 (file)
@@ -1682,7 +1682,7 @@ public class NumberFormatterApiTest extends TestFmwk {
                            6.6,                  //
                            "36 mpg");
 
-        // // TODO(ICU-21862): determine desired behaviour. Commented out for now
+        // // TODO(ICU-21988): determine desired behaviour. Commented out for now
         // // to not enforce undesirable behaviour
         // assertFormatSingle("Fuel consumption: inverted units, divide-by-zero, en-US",
         //                    "unit/liter-per-100-kilometer usage/vehicle-fuel",
@@ -1694,7 +1694,7 @@ public class NumberFormatterApiTest extends TestFmwk {
         //                    0,                    //
         //                    "0 mpg");
 
-        // // TODO(ICU-21862): determine desired behaviour. Commented out for now
+        // // TODO(ICU-21988): determine desired behaviour. Commented out for now
         // // to not enforce undesirable behaviour
         // assertFormatSingle("Fuel consumption: inverted units, divide-by-zero, en-ZA",
         //                    "unit/mile-per-gallon usage/vehicle-fuel",
@@ -1706,7 +1706,7 @@ public class NumberFormatterApiTest extends TestFmwk {
         //                    0,                    //
         //                    "0 mpg");
 
-        // // TODO(ICU-21862): Once we support Inf as input:
+        // // TODO(ICU-21988): Once we support Inf as input:
         // assertFormatSingle("Fuel consumption: inverted units, divide-by-inf",
         //                    "unit/mile-per-gallon usage/vehicle-fuel",
         //                    "unit/mile-per-gallon usage/vehicle-fuel",