Fixed bugs #71317 and #71504

If there are duplicate filenames in tar, the last one wins.

diff --git a/NEWS b/NEWS
index 3938a4ed7a1f18f80e1ee18de1d6b25c52bb1df3..d0575da9e928b1f63be43e147f1ef3bf2bb1bafa 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -17,6 +17,8 @@ PHP                                                                        NEWS
 - Phar:
   . Fixed bug #71625 (Crash in php7.dll with bad phar filename).
     (Anatol)
+  . Fixed bug #71504 (Parsing of tar file with duplicate filenames causes
+    memory leak). (Jos Elstgeest)
 
 03 Mar 2016, PHP 5.6.19
 

diff --git a/ext/phar/tar.c b/ext/phar/tar.c
index 1fcfe527561e2e411d7a91683504e92c3b5b6deb..62edcb59f1226222b50abd8877e801e20dc206c6 100644 (file)
--- a/ext/phar/tar.c
+++ b/ext/phar/tar.c
@@ -500,7 +500,9 @@ bail:
                        entry.link = estrndup(hdr->linkname, linkname_len);
                }
                phar_set_inode(&entry TSRMLS_CC);
-               zend_hash_add(&myphar->manifest, entry.filename, entry.filename_len, (void*)&entry, sizeof(phar_entry_info), (void **) &newentry);
+
+               zend_hash_update(&myphar->manifest, entry.filename, entry.filename_len, (void*)&entry, sizeof(phar_entry_info), (void **) &newentry);
+               ZEND_ASSERT(newentry != NULL);
 
                if (entry.is_persistent) {
                        ++entry.manifest_pos;

diff --git a/ext/phar/tests/tar/bug71317-duplicate-filename.phpt b/ext/phar/tests/tar/bug71317-duplicate-filename.phpt
new file mode 100644 (file)
index 0000000..bcbccab
--- /dev/null
+++ b/ext/phar/tests/tar/bug71317-duplicate-filename.phpt
@@ -0,0 +1,50 @@
+--TEST--
+Bug #71317: regression in opening tar based phar files
+--SKIPIF--
+<?php if (!extension_loaded('phar')) die('skip'); ?>
+<?php if (!extension_loaded("spl")) die("skip SPL not available"); ?>
+<?php if (!extension_loaded("zlib")) die("skip zlib not available"); ?>
+--FILE--
+<?php
+include dirname(__FILE__) . '/files/tarmaker.php.inc';
+
+$testDirectory = __DIR__ . '/files/test_bug71317';
+$testTarFilename  = __DIR__ . '/files/test_bug71317.tar';
+
+$tar = new tarmaker($testTarFilename, 'none');
+$tar->init();
+$tar->addFile('file1.txt', 'file1');
+$tar->addFile('file2.txt', 'file2');
+$tar->addFile('file3.txt', 'file3');
+$tar->addFile('file4.txt', 'file4');
+$tar->addFile('file5.txt', 'file5');
+$tar->addFile('file2.txt', 'file2a');
+$tar->close();
+
+$fname = str_replace('\\', '/', $testTarFilename);
+try {
+       mkdir($testDirectory);
+       $tar = new PharData($fname);
+       $tar->extractTo($testDirectory);
+
+       $fileContent = file_get_contents($testDirectory . '/file2.txt');
+       $expectedContent = 'file2a';
+       if ($fileContent !== $expectedContent) {
+               throw new Exception(sprintf('Contents of file2.txt ("%s") is invalid, expected "%s"', $fileContent, $expectedContent));
+       }
+} catch(Exception $e) {
+       echo $e->getMessage() . "\n";
+}
+?>
+===DONE===
+--CLEAN--
+<?php
+$testDirectory = __DIR__ . '/files/test_bug71317';
+$testTarFilename  = __DIR__ . '/files/test_bug71317.tar';
+
+unlink($testTarFilename);
+array_map('unlink', glob($testDirectory . "/*.txt"));
+rmdir($testDirectory);
+?>
+--EXPECT--
+===DONE===

diff --git a/ext/phar/tests/tar/bug71504.phpt b/ext/phar/tests/tar/bug71504.phpt
new file mode 100644 (file)
index 0000000..e850788
--- /dev/null
+++ b/ext/phar/tests/tar/bug71504.phpt
@@ -0,0 +1,18 @@
+--TEST--
+Bug #71504: Parsing of tar file with duplicate filenames causes memory leak
+--SKIPIF--
+<?php if (!extension_loaded('phar')) die('skip'); ?>
+<?php if (!extension_loaded("spl")) die("skip SPL not available"); ?>
+<?php if (!extension_loaded("zlib")) die("skip zlib not available"); ?>
+--FILE--
+<?php
+$fname = str_replace('\\', '/', dirname(__FILE__) . '/files/HTML_CSS-1.5.4.tgz');
+try {
+       $tar = new PharData($fname);
+} catch(Exception $e) {
+       echo $e->getMessage() . "\n";
+}
+?>
+===DONE===
+--EXPECT--
+===DONE===

diff --git a/ext/phar/tests/tar/files/HTML_CSS-1.5.4.tgz b/ext/phar/tests/tar/files/HTML_CSS-1.5.4.tgz
new file mode 100644 (file)
index 0000000..d0b2313
Binary files /dev/null and b/ext/phar/tests/tar/files/HTML_CSS-1.5.4.tgz differ