Issue 7911: unittest.TestCase.longMessage defaults to True for improved failure messa...

diff --git a/Doc/library/unittest.rst b/Doc/library/unittest.rst
index db6c53fc0958d3e4bafb7758c67dc1e788933e05..2b9c2be1a3c255a7d4863e72fe00bf84715c89d6 100644 (file)
--- a/Doc/library/unittest.rst
+++ b/Doc/library/unittest.rst
@@ -1305,8 +1305,8 @@ Test cases
       to ``True`` allows you to have a custom error message in addition to the
       normal one.
 
-      This attribute defaults to ``False``, meaning that a custom message passed
-      to an assert method will silence the normal message.
+      This attribute defaults to ``True``. If set to False then a custom message
+      passed to an assert method will silence the normal message.
 
       The class setting can be overridden in individual tests by assigning an
       instance attribute to ``True`` or ``False`` before calling the assert methods.

diff --git a/Lib/unittest/case.py b/Lib/unittest/case.py
index bb337f1da2fce9ed80dbab9b1d516f2334883106..227879cb6d4361d12b4d21624f68d62a85b4d5df 100644 (file)
--- a/Lib/unittest/case.py
+++ b/Lib/unittest/case.py
@@ -245,7 +245,7 @@ class TestCase(object):
     # objects used in assert methods) will be printed on failure in *addition*
     # to any explicit message passed.
 
-    longMessage = False
+    longMessage = True
 
     # This attribute sets the maximum length of a diff in failure messages
     # by assert methods using difflib. It is looked up as an instance attribute

diff --git a/Lib/unittest/test/test_assertions.py b/Lib/unittest/test/test_assertions.py
index 0ee7edbd041d585dc5409e907b964fe3fc2224c4..69572eee19025584f9329af9677a4c6e4f776a2b 100644 (file)
--- a/Lib/unittest/test/test_assertions.py
+++ b/Lib/unittest/test/test_assertions.py
@@ -127,7 +127,7 @@ class TestLongMessage(unittest.TestCase):
         self.testableFalse = TestableTestFalse('testTest')
 
     def testDefault(self):
-        self.assertFalse(unittest.TestCase.longMessage)
+        self.assertTrue(unittest.TestCase.longMessage)
 
     def test_formatMsg(self):
         self.assertEqual(self.testableFalse._formatMessage(None, "foo"), "foo")

diff --git a/Misc/NEWS b/Misc/NEWS
index b0975f8f6c249ab87e318b2afb27a45ab8ac6381..e856c6de5af7af3be1faf9f285b1e2ab8f483e47 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@ What's New in Python 3.2 Beta 1?
 Core and Builtins
 -----------------
 
+- Issue 7911: `unittest.TestCase.longMessage` defaults to True for improved
+  failure messages by default. Patch by Mark Roddy.
+  
 - Issue #9915: Speed up sorting with a key.
 
 - Issue #9333: Expose os.symlink only when the SeCreateSymbolicLinkPrivilege