]> granicus.if.org Git - procps-ng/commitdiff
library: Better PID file checks (with one small tweak)
authorJim Warner <james.warner@comcast.net>
Fri, 7 Jan 2022 06:00:00 +0000 (00:00 -0600)
committerCraig Small <csmall@dropbear.xyz>
Thu, 13 Jan 2022 08:34:39 +0000 (19:34 +1100)
Since gcc no longer warns of 'unreachable code', we'll
just deal with any such possibility ourselves I guess.

Signed-off-by: Jim Warner <james.warner@comcast.net>
proc/readproc.c

index cc55cdfc33a79dfdfe735f7138d0a710a9b3557c..a956f43822ad178d2f8794de314956cf0ef76fca 100644 (file)
@@ -1365,7 +1365,7 @@ static int simple_nextpid(PROCTAB *restrict const PT, proc_t *restrict const p)
     char *restrict const path = PT->path;
     for (;;) {
         ent = readdir(PT->procfs);
-        if (!ent || !ent->d_name[0]) return 0;
+        if (!ent || !ent->d_name[0]) break;
         if (*ent->d_name > '0' && *ent->d_name <= '9') {
             errno = 0;
             p->tgid = strtoul(ent->d_name, NULL, 10);