remove assignment in conditional

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index e9feba378e6021d824760a9b08e7ea28ca7cabed..e9e482e874608ab1fc7c6aefb9d0281be0a0f408 100644 (file)
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -5268,7 +5268,8 @@ socket_getaddrinfo(PyObject *self, PyObject *args, PyObject* kwargs)
         goto err;
     }
 
-    if ((all = PyList_New(0)) == NULL)
+    all = PyList_New(0);
+    if (all == NULL)
         goto err;
     for (res = res0; res; res = res->ai_next) {
         PyObject *single;