]> granicus.if.org Git - pdns/commitdiff
rfc2136handler: Close socket when write fails
authorChristian Hofstaedtler <christian@hofstaedtler.name>
Wed, 28 Aug 2013 18:23:45 +0000 (20:23 +0200)
committerChristian Hofstaedtler <christian@hofstaedtler.name>
Wed, 28 Aug 2013 18:23:45 +0000 (20:23 +0200)
Fix for Coverity CID 1066217.

pdns/rfc2136handler.cc

index ae2fe7e4b8b7abde0d0d37806db3b85d7f70de33..4e3d1167326542253b2bdcdd3f88daf79ed33246 100644 (file)
@@ -611,6 +611,7 @@ int PacketHandler::forwardPacket(const string &msgPrefix, DNSPacket *p, DomainIn
     buffer.append(forwardPacket.getString());
     if(write(sock, buffer.c_str(), buffer.length()) < 0) {
       L<<Logger::Error<<msgPrefix<<"Unable to forward update message to "<<remote.toStringWithPort()<<", error:"<<stringerror()<<endl;
+      Utility::closesocket(sock);
       continue;
     }