]> granicus.if.org Git - llvm/commitdiff
[PM] Remove now-dead extern template and explicit instantiation
authorChandler Carruth <chandlerc@gmail.com>
Thu, 22 Dec 2016 07:14:33 +0000 (07:14 +0000)
committerChandler Carruth <chandlerc@gmail.com>
Thu, 22 Dec 2016 07:14:33 +0000 (07:14 +0000)
declarations.

We're using a custom class here instead of the helper template, these
bits just didn't get deleted when the other bits did get deleted. This
was found by a really nice MSVC warning about explicitly instantiating
a template where some member functions aren't defined and thus can't be
instantiatied.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290327 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/Analysis/CGSCCPassManager.h
lib/Analysis/CGSCCPassManager.cpp

index 8eaa771afce3e652c559704637813f80efc4509d..73f462e4bf1eee4358d8379a22a2c0ca9db9cbe2 100644 (file)
@@ -489,11 +489,6 @@ private:
   static AnalysisKey Key;
 };
 
-// Ensure the \c FunctionAnalysisManagerCGSCCProxy is provided as an extern
-// template.
-extern template class InnerAnalysisManagerProxy<
-    FunctionAnalysisManager, LazyCallGraph::SCC, LazyCallGraph &>;
-
 extern template class OuterAnalysisManagerProxy<CGSCCAnalysisManager, Function>;
 /// A proxy from a \c CGSCCAnalysisManager to a \c Function.
 typedef OuterAnalysisManagerProxy<CGSCCAnalysisManager, Function>
index 5c1485d02de50a7c9ae16e8f810c27fb77cc52a8..2fa258bffea19713054cca21f26af588f29ecd63 100644 (file)
@@ -25,8 +25,6 @@ template class PassManager<LazyCallGraph::SCC, CGSCCAnalysisManager,
 template class InnerAnalysisManagerProxy<CGSCCAnalysisManager, Module>;
 template class OuterAnalysisManagerProxy<ModuleAnalysisManager,
                                          LazyCallGraph::SCC, LazyCallGraph &>;
-template class InnerAnalysisManagerProxy<FunctionAnalysisManager,
-                                         LazyCallGraph::SCC, LazyCallGraph &>;
 template class OuterAnalysisManagerProxy<CGSCCAnalysisManager, Function>;
 
 /// Explicitly specialize the pass manager run method to handle call graph