[test] Disable dsymutil update test on windows

Apparently, the issue with dsymutil update functionality on Windows was
that Windows doesn't like dsymutil renaming files that have open handles
to them. This disables the new accelerator test and updates the comment
in the other two test.

We should be able to enable the tests again once we updated the
implementation to use TempFile::keep() to keep the temporary files in
MachOUtils.

A big thank you to Jeremy Morse from Sony for figuring this out and
bringing it to my attention.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@338030 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/tools/dsymutil/X86/accelerator.test b/test/tools/dsymutil/X86/accelerator.test
index 96fc58ee5683959044a884ee3bed274b573c6380..906b0e645cf4f5cf2aaeade53feb2131b29ce651 100644 (file)
--- a/test/tools/dsymutil/X86/accelerator.test
+++ b/test/tools/dsymutil/X86/accelerator.test
@@ -1,3 +1,7 @@
+UNSUPPORTED: system-windows
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
+
 RUN: dsymutil -accelerator=Dwarf -oso-prepend-path=%p/.. %p/../Inputs/basic.macho.x86_64 -o %t.dwarf.dSYM
 RUN: dsymutil -accelerator=Apple -oso-prepend-path=%p/.. %p/../Inputs/basic.macho.x86_64 -o %t.apple.dSYM
 

diff --git a/test/tools/dsymutil/X86/update-one-CU.test b/test/tools/dsymutil/X86/update-one-CU.test
index 0759334a62ed6e220580d66707bca4bf75de823b..5d36ce7135f2eb861f35f0463852ea5583d9bc10 100644 (file)
--- a/test/tools/dsymutil/X86/update-one-CU.test
+++ b/test/tools/dsymutil/X86/update-one-CU.test
@@ -1,5 +1,6 @@
 UNSUPPORTED: system-windows
-Remove UNSUPPORTED once we figure out why this fails on Windows.
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
 
 RUN: dsymutil -oso-prepend-path=%p/.. %p/../Inputs/objc.macho.x86_64 -o %t.dSYM
 RUN: dsymutil -update %t.dSYM

diff --git a/test/tools/dsymutil/X86/update.test b/test/tools/dsymutil/X86/update.test
index 93e9b3617a6fd01f6325cdae8e6f68a0f1529365..cbfff63d6a87487343059f1daf8231f19303cb66 100644 (file)
--- a/test/tools/dsymutil/X86/update.test
+++ b/test/tools/dsymutil/X86/update.test
@@ -1,5 +1,6 @@
 UNSUPPORTED: system-windows
-Remove UNSUPPORTED once we figure out why this fails on Windows.
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
 
 RUN: rm -rf %t.dir
 RUN: mkdir -p %t.dir