]> granicus.if.org Git - php/commitdiff
Fix UConvert::getErrorMessage() leak on zpp failure
authorNikita Popov <nikita.ppv@gmail.com>
Tue, 21 Jul 2020 10:02:00 +0000 (12:02 +0200)
committerNikita Popov <nikita.ppv@gmail.com>
Tue, 21 Jul 2020 10:05:44 +0000 (12:05 +0200)
ext/intl/converter/converter.c

index 5151daaa3637903b17b7dad8437c47bf37bdb8ce..72144a4ee185b16a94d91b94907e15e6e86ce099 100644 (file)
@@ -797,12 +797,12 @@ PHP_METHOD(UConverter, getErrorCode) {
 /* {{{ */
 PHP_METHOD(UConverter, getErrorMessage) {
        php_converter_object *objval = CONV_GET(ZEND_THIS);
-       zend_string *message = intl_error_get_message(&(objval->error));
 
        if (zend_parse_parameters_none() == FAILURE) {
                RETURN_THROWS();
        }
 
+       zend_string *message = intl_error_get_message(&(objval->error));
        if (message) {
                RETURN_STR(message);
        } else {