Use 'vfprintf' instead of 'fprintf' to print variadic arguments.

Added GCC warninigs -Wformat=2 (reveals this error) and
-Wsuggest-attribute=format.

diff --git a/re2c/configure.ac b/re2c/configure.ac
index 693e3ba7d0c5e76ea7c10d264e72aa41a4ea684c..dc49d1a1731065f2613014721ad379d03cd822c9 100644 (file)
--- a/re2c/configure.ac
+++ b/re2c/configure.ac
@@ -58,7 +58,9 @@ TRY_CXXFLAG([-Wall])
 TRY_CXXFLAG([-Wextra])
 TRY_CXXFLAG([-Weffc++])
 TRY_CXXFLAG([-pedantic])
+TRY_CXXFLAG([-Wformat=2])
 TRY_CXXFLAG([-Wredundant-decls])
+TRY_CXXFLAG([-Wsuggest-attribute=format])
 TRY_CXXFLAG([-O2])
 TRY_CXXFLAG([-Weverything])
 

diff --git a/re2c/src/conf/msg.cc b/re2c/src/conf/msg.cc
index 2becf9709de77d851eec46d2eca16777d47f549f..9e3af72fb175618901e65dcdafc6289845fa2c41 100644 (file)
--- a/re2c/src/conf/msg.cc
+++ b/re2c/src/conf/msg.cc
@@ -13,7 +13,7 @@ void error (const char * fmt, ...)
 
        va_list args;
        va_start (args, fmt);
-       fprintf (stderr, fmt, args);
+       vfprintf (stderr, fmt, args);
        va_end (args);
 }