]> granicus.if.org Git - python/commitdiff
Fix problem (not checking return result) reported by Coverity
authorNeal Norwitz <nnorwitz@gmail.com>
Sun, 9 Apr 2006 04:07:39 +0000 (04:07 +0000)
committerNeal Norwitz <nnorwitz@gmail.com>
Sun, 9 Apr 2006 04:07:39 +0000 (04:07 +0000)
Modules/_sqlite/cursor.c

index b9ed56af00df742d037253bb232b6cc04195a5d6..c6b8c77a0f168af0f5f5dceb8d8fd66364136f0e 100644 (file)
@@ -455,6 +455,9 @@ PyObject* _query_execute(Cursor* self, int multiple, PyObject* args)
         Py_DECREF(second_argument);
 
         parameters_iter = PyObject_GetIter(parameters_list);
+        if (!parameters_iter) {
+            goto error;
+        }
     }
 
     if (self->statement != NULL) {
@@ -670,7 +673,7 @@ PyObject* _query_execute(Cursor* self, int multiple, PyObject* args)
 error:
     Py_XDECREF(operation_bytestr);
     Py_XDECREF(parameters);
-    Py_DECREF(parameters_iter);
+    Py_XDECREF(parameters_iter);
     Py_XDECREF(parameters_list);
 
     if (PyErr_Occurred()) {