mfg_util: Add support for comments in input config csv file only

diff --git a/tools/mass_mfg/docs/README.rst b/tools/mass_mfg/docs/README.rst
index ba43dd5e9f1874ce1427496fa0e6ef8310c85fdc..3690c92432b8097624f7455e167c801a7c92f599 100644 (file)
--- a/tools/mass_mfg/docs/README.rst
+++ b/tools/mass_mfg/docs/README.rst
@@ -181,3 +181,5 @@ The mfg\_gen.py utility is using the generated CSV Configuration file and Master
 .. note:: The default numeric value: 1,2,3... of ``fileid`` argument, corresponds to each row having device instance values in master csv values file.
 
 .. note:: ``bin/`` **and** ``csv/`` **sub-directories are created in the** ``outdir`` **directory specified while running this utility. The binary files generated will be stored in** ``bin/`` **and the intermediate csv files generated will be stored in** ``csv/``.
+
+.. note:: Comments are supported in input config csv file only.

diff --git a/tools/mass_mfg/mfg_gen.py b/tools/mass_mfg/mfg_gen.py
index ecaa4319b676d4b57eac434dcb6d0824ac777774..302bcc3c6fb6a2866a419592de414360dcc44b8c 100755 (executable)
--- a/tools/mass_mfg/mfg_gen.py
+++ b/tools/mass_mfg/mfg_gen.py
@@ -55,7 +55,7 @@ def verify_keys_exist(values_file_keys, input_config_file):
     keys_missing = []
 
     config_file = open(input_config_file,'r')
-    config_file_reader = csv.reader(config_file, delimiter=',')
+    config_file_reader = csv.reader(filter(lambda row: row[0] != '#',config_file), delimiter=',')
     for line_no, config_data in enumerate(config_file_reader,1):
         if 'namespace' not in config_data:
             if values_file_keys:
@@ -84,7 +84,7 @@ def verify_datatype_encoding(input_config_file):
     line_no = 0
 
     config_file = open(input_config_file,'r')
-    config_file_reader = csv.reader(config_file, delimiter=',')
+    config_file_reader = csv.reader(filter(lambda row: row[0] != '#',config_file), delimiter=',')
     for config_data in config_file_reader:
         line_no += 1
         if config_data[1] not in valid_datatypes:
@@ -102,7 +102,7 @@ def verify_file_data_count(input_config_file, keys_repeat):
     """
     line_no = 0
     config_file = open(input_config_file, 'r')
-    config_file_reader = csv.reader(config_file, delimiter=',')
+    config_file_reader = csv.reader(filter(lambda row: row[0] != '#',config_file), delimiter=',')
     for line in config_file_reader:
         line_no += 1
         if len(line) != 3 and line[0] not in keys_repeat:
@@ -155,7 +155,7 @@ def add_config_data_per_namespace(input_config_file):
     config_data_per_namespace = []
 
     csv_config_file = open(input_config_file,'r')
-    config_file_reader = csv.reader(csv_config_file, delimiter=',')
+    config_file_reader = csv.reader(filter(lambda row: row[0] != '#',csv_config_file), delimiter=',')
 
     # `config_data_per_namespace` is added to `config_data_to_write` list after reading next namespace
     for config_data in config_file_reader:
@@ -515,7 +515,6 @@ def main(input_config_file=None,input_values_file=None,target_file_name_prefix=N
                 output_target_dir = create_dir("bin/", output_dir_path)
 
                 # Verify if output bin file does not exist
-                # todo for keys
                 output_file_prefix = target_file_name_prefix + "-" + file_identifier_value
                 output_bin_file = output_target_dir + output_file_prefix + ".bin"
                 if os.path.isfile(output_bin_file):

diff --git a/tools/mass_mfg/samples/sample_config.csv b/tools/mass_mfg/samples/sample_config.csv
index dc5167159140795d8276e88bd6e5f154311bcb32..101684d06bc422fd36aa9e7eeef9de724876e733 100644 (file)
--- a/tools/mass_mfg/samples/sample_config.csv
+++ b/tools/mass_mfg/samples/sample_config.csv
@@ -1,3 +1,4 @@
+# Sample config file
 dummyNamespace,namespace,
 dummyU8Key,data,u8
 dummyI8Key,data,i8