]> granicus.if.org Git - llvm/commitdiff
[X86] Mark the default case of the X86InstrInfo::convertToThreeAddress switch as...
authorCraig Topper <craig.topper@intel.com>
Tue, 2 Apr 2019 20:52:16 +0000 (20:52 +0000)
committerCraig Topper <craig.topper@intel.com>
Tue, 2 Apr 2019 20:52:16 +0000 (20:52 +0000)
This function should only be called with instructions that are really convertible. And all
convertible instructions need to be handled by the switch. So nothing should use the default.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@357529 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/X86/X86InstrInfo.cpp

index e157bc13ec24749601dd73a917800a20c9b45478..4aa365cf8fe38fb676d38bbea19de85dec5bb9f5 100644 (file)
@@ -869,7 +869,7 @@ X86InstrInfo::convertToThreeAddress(MachineFunction::iterator &MFI,
   bool Is8BitOp = false;
   unsigned MIOpc = MI.getOpcode();
   switch (MIOpc) {
-  default: return nullptr;
+  default: llvm_unreachable("Unreachable!");
   case X86::SHL64ri: {
     assert(MI.getNumOperands() >= 3 && "Unknown shift instruction!");
     unsigned ShAmt = getTruncatedShiftCount(MI, 2);