]> granicus.if.org Git - python/commitdiff
Fix incorrect error handling in _pickle.Unpickler.__init__() (GH-9630)
authorZackery Spytz <zspytz@gmail.com>
Sat, 29 Sep 2018 05:48:46 +0000 (23:48 -0600)
committerSerhiy Storchaka <storchaka@gmail.com>
Sat, 29 Sep 2018 05:48:46 +0000 (08:48 +0300)
_pickle.Unpickler.__init__() should return -1 if Pdata_New() fails, not 1.

Modules/_pickle.c

index 3588e33f097165b4c128bed5564dde91c5fb5aa3..0e3bd225dbd823ad7136363fd0a9d14f67bb2848 100644 (file)
@@ -6792,7 +6792,7 @@ _pickle_Unpickler___init___impl(UnpicklerObject *self, PyObject *file,
 
     self->stack = (Pdata *)Pdata_New();
     if (self->stack == NULL)
-        return 1;
+        return -1;
 
     self->memo_size = 32;
     self->memo = _Unpickler_NewMemo(self->memo_size);