Avoid assignments in comparisons.

diff --git a/src/chfn.c b/src/chfn.c
index 6607cb09c9d0d739c9e4859bfc326de7c66a5cb2..3baea8f8326c395a4448526cf25d2b60948fd830 100644 (file)
--- a/src/chfn.c
+++ b/src/chfn.c
@@ -210,7 +210,8 @@ static char *copy_field (char *in, char *out, char *extra)
        char *cp = NULL;
 
        while (NULL != in) {
-               if ((cp = strchr (in, ',')) != NULL) {
+               cp = strchr (in, ',');
+               if (NULL != cp) {
                        *cp++ = '\0';
                }