]> granicus.if.org Git - clang/commitdiff
Improve understanding post increment and decrement.
authorDaniel Jasper <djasper@google.com>
Mon, 14 Jan 2013 12:18:19 +0000 (12:18 +0000)
committerDaniel Jasper <djasper@google.com>
Mon, 14 Jan 2013 12:18:19 +0000 (12:18 +0000)
Before: (a->f()) ++;
        a[42] ++;
After:  (a->f())++;
        a[42]++;

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@172400 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Format/Format.cpp
unittests/Format/FormatTest.cpp

index 548bdee2b2d4727eca14935b37ec421f580aab9e..57e9a769892bd940470dacbd59e7bdf2d692d0a7 100644 (file)
@@ -1060,7 +1060,10 @@ private:
 
   /// \brief Determine whether ++/-- are pre- or post-increments/-decrements.
   TokenType determineIncrementUsage(const AnnotatedToken &Tok) {
-    if (Tok.Parent != NULL && Tok.Parent->is(tok::identifier))
+    if (Tok.Parent == NULL)
+      return TT_UnaryOperator;
+    if (Tok.Parent->is(tok::r_paren) || Tok.Parent->is(tok::r_square) ||
+        Tok.Parent->is(tok::identifier))
       return TT_TrailingUnaryOperator;
 
     return TT_UnaryOperator;
index eb87a3b965717d1f9e73272df4eea4a8e7dec392..9565e3a855343bbca56a0c151dfbf29cce723d0e 100644 (file)
@@ -978,6 +978,8 @@ TEST_F(FormatTest, UnderstandsUnaryOperators) {
   verifyFormat("if (i < -1) {}");
   verifyFormat("++(a->f());");
   verifyFormat("--(a->f());");
+  verifyFormat("(a->f())++;");
+  verifyFormat("a[42]++;");
   verifyFormat("if (!(a->f())) {}");
 
   verifyFormat("a-- > b;");