increase code coverage

diff --git a/ext/phar/tests/phar_isvalidpharfilename.phpt b/ext/phar/tests/phar_isvalidpharfilename.phpt
index f5b0c8d70e3938847364479bce020d7451595e63..32b5bef29e89f5c2aa9d01d4874e00da70dadf98 100644 (file)
--- a/ext/phar/tests/phar_isvalidpharfilename.phpt
+++ b/ext/phar/tests/phar_isvalidpharfilename.phpt
@@ -72,6 +72,11 @@ var_dump(Phar::isValidPharFilename('myphar.phar'));
 var_dump(Phar::isValidPharFilename('myphar.phar', true));
 var_dump(Phar::isValidPharFilename('myphar.phar', false));
 
+echo "\ndir.phar.php\n";
+var_dump(Phar::isValidPharFilename('dir.phar.php'));
+var_dump(Phar::isValidPharFilename('dir.phar.php', true));
+var_dump(Phar::isValidPharFilename('dir.phar.php', false));
+
 ?>
 ===DONE===
 --CLEAN--
@@ -138,5 +143,10 @@ myphar.phar
 bool(true)
 bool(true)
 bool(false)
+
+dir.phar.php
+bool(true)
+bool(true)
+bool(false)
 ===DONE===
 

diff --git a/ext/phar/tests/phar_oo_001.phpt b/ext/phar/tests/phar_oo_001.phpt
index 616b2ec0ac0546d464d6b3c4b91d063926b5de39..81d57d1bfc8422c988c10afe81c70eb91322c5d6 100755 (executable)
--- a/ext/phar/tests/phar_oo_001.phpt
+++ b/ext/phar/tests/phar_oo_001.phpt
@@ -5,6 +5,7 @@ Phar object: basics
 <?php if (!extension_loaded("spl")) die("skip SPL not available"); ?>
 --INI--
 phar.require_hash=0
+phar.readonly=0
 --FILE--
 <?php
 
@@ -30,6 +31,13 @@ catch (BadMethodCallException $e)
 {
        var_dump($e->getMessage());
 }
+try {
+       $phar = new Phar('test.phar');
+       $phar->__construct('oops');
+} catch (BadMethodCallException $e)
+{
+       var_dump($e->getMessage());
+}
 
 ?>
 ===DONE===
@@ -42,4 +50,5 @@ __halt_compiler();
 string(5) "1.0.0"
 int(5)
 string(50) "Cannot call method on an uninitialized Phar object"
+string(29) "Cannot call constructor twice"
 ===DONE===