MFH: Fail loudly. This is too often reported as a "bug".

diff --git a/NEWS b/NEWS
index d1fd51621f5c30e80b6103b8835a883d28a34805..c775806e2c1d9828ebe30f0aceaae8c625548c18 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ PHP 4                                                                      NEWS
   (Edin)
 - Added support for --program-prefix and --program-suffix configure options.
   (Jani)
+- Added warning when unable to create temp stream for ftp_(n)list(). (Sara)
 - Fixed header handler in NSAPI SAPI module (header->replace was ignored,
   send_default_content_type now sends value from php.ini). (Uwe Schindler)
 - Fixed bug #26635 (fixed look up for fonts in the current directory w/ZTS).

diff --git a/ext/ftp/ftp.c b/ext/ftp/ftp.c
index 01710ec6565a2749181ba99216e61f653d561fec..7e9f314cbb304b17c8cd63cd3d9d2a89ba4e8134 100644 (file)
--- a/ext/ftp/ftp.c
+++ b/ext/ftp/ftp.c
@@ -1460,8 +1460,10 @@ ftp_genlist(ftpbuf_t *ftp, const char *cmd, const char *path TSRMLS_DC)
        char            **entry;
        char            *text;
 
-       if ((tmpfp = tmpfile()) == NULL)
+       if ((tmpfp = tmpfile()) == NULL) {
+               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Unable to create temporary file.  Check permissions in temporary files directory.");
                return NULL;
+       }
 
        if (!ftp_type(ftp, FTPTYPE_ASCII))
                goto bail;