Merged revisions 79518 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r79518 | brian.curtin | 2010-03-30 22:10:21 -0500 (Tue, 30 Mar 2010) | 2 lines

  Fix #8225. xml.etree was displaying an incorrect link when viewed in help.
........

diff --git a/Lib/pydoc.py b/Lib/pydoc.py
index 4a8017ef53d4af1c46862a3a41d9d195aba0a193..62ca3b0d3587c1037cafbfef3d81f07b009290e8 100755 (executable)
--- a/Lib/pydoc.py
+++ b/Lib/pydoc.py
@@ -349,7 +349,8 @@ class Doc:
                                  'marshal', 'posix', 'signal', 'sys',
                                  '_thread', 'zipimport') or
              (file.startswith(basedir) and
-              not file.startswith(os.path.join(basedir, 'site-packages'))))):
+              not file.startswith(os.path.join(basedir, 'site-packages')))) and
+            object.__name__ not in ('xml.etree')):
             if docloc.startswith("http://"):
                 docloc = "%s/%s" % (docloc.rstrip("/"), object.__name__)
             else:

diff --git a/Lib/test/test_pydoc.py b/Lib/test/test_pydoc.py
index a2b87c3389ec4430970092b3ecfd98f17d2e4be4..d0b81e35d884a7191adcfd10cfcce88a4a31c226 100644 (file)
--- a/Lib/test/test_pydoc.py
+++ b/Lib/test/test_pydoc.py
@@ -8,6 +8,7 @@ import pydoc
 import inspect
 import unittest
 import test.support
+import xml.etree
 from contextlib import contextmanager
 from test.support import (
     TESTFN, forget, rmtree, EnvironmentVarGuard, reap_children)
@@ -265,6 +266,11 @@ class PyDocDocTest(unittest.TestCase):
             print_diffs(expected_text, result)
             self.fail("outputs are not equal, see diff above")
 
+    def test_issue8225(self):
+        # Test issue8225 to ensure no doc link appears for xml.etree
+        result, doc_loc = get_pydoc_text(xml.etree)
+        self.assertEqual(doc_loc, "", "MODULE DOCS incorrectly includes a link")
+
     def test_not_here(self):
         missing_module = "test.i_am_not_here"
         result = str(run_pydoc(missing_module), 'ascii')