Fix thinko in re-setting wal_log_hints flag from a parameter-change record.

The flag is supposed to be copied from the record. Same issue with
track_commit_timestamps, but that's master-only.

Report and fix by Petr Jalinek. Backpatch to 9.4, where wal_log_hints was
added.

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 839ea7c7a0559c214e4d6b021725ea75ce9f304c..629a457965ff2e6987bd6ccd5ee0cabb26fe212c 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -8962,8 +8962,8 @@ xlog_redo(XLogReaderState *record)
                ControlFile->max_prepared_xacts = xlrec.max_prepared_xacts;
                ControlFile->max_locks_per_xact = xlrec.max_locks_per_xact;
                ControlFile->wal_level = xlrec.wal_level;
-               ControlFile->wal_log_hints = wal_log_hints;
-               ControlFile->track_commit_timestamp = track_commit_timestamp;
+               ControlFile->wal_log_hints = xlrec.wal_log_hints;
+               ControlFile->track_commit_timestamp = xlrec.track_commit_timestamp;
 
                /*
                 * Update minRecoveryPoint to ensure that if recovery is aborted, we