]> granicus.if.org Git - clang/commitdiff
[ms-abi][cleanup] Removing FinalizeCXXLayout : no functional change
authorWarren Hunt <whunt@google.com>
Wed, 11 Dec 2013 22:28:32 +0000 (22:28 +0000)
committerWarren Hunt <whunt@google.com>
Wed, 11 Dec 2013 22:28:32 +0000 (22:28 +0000)
After r196549 there is no need to separate FinalizeCXXLayout and
FinalizeLayout so they were merged and FinalizeCXXLayout was eliminated.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@197083 91177308-0d34-0410-b5e6-96231b3b80d8

lib/AST/RecordLayoutBuilder.cpp

index 112e6d6981d5375d857a87fa00c389328eab31be..5e68ad249e7377f98c5a9d9a768eec53efa63a3a 100644 (file)
@@ -2063,9 +2063,6 @@ public:
   void fixSizeAndAlignment(const RecordDecl *FD);
   void layoutVirtualBases(const CXXRecordDecl *RD);
   void layoutVirtualBase(const CXXRecordDecl *RD, bool HasVtordisp);
-  /// \brief Flushes the lazy virtual base and conditionally rounds up to
-  /// alignment.
-  void finalizeCXXLayout(const CXXRecordDecl *RD);
   void finalizeLayout(const RecordDecl *RD);
 
   /// \brief Updates the alignment of the type.  This function doesn't take any
@@ -2245,7 +2242,6 @@ void MicrosoftRecordLayoutBuilder::cxxLayout(const CXXRecordDecl *RD) {
   layoutFields(RD);
   fixSizeAndAlignment(RD);
   layoutVirtualBases(RD);
-  finalizeCXXLayout(RD);
   finalizeLayout(RD);
 }
 
@@ -2613,18 +2609,13 @@ void MicrosoftRecordLayoutBuilder::layoutVirtualBase(const CXXRecordDecl *RD,
   PreviousBaseLayout = &Layout;
 }
 
-void MicrosoftRecordLayoutBuilder::finalizeCXXLayout(const CXXRecordDecl *RD) {
-  if (RD->vbases_begin() == RD->vbases_end() || !RequiredAlignment.isZero())
-    Size = Size.RoundUpToAlignment(Alignment);
-
+void MicrosoftRecordLayoutBuilder::finalizeLayout(const RecordDecl *RD) {
   if (Size.isZero()) {
     HasZeroSizedSubObject = true;
     LeadsWithZeroSizedBase = true;
     Size = Alignment;
   }
-}
 
-void MicrosoftRecordLayoutBuilder::finalizeLayout(const RecordDecl *RD) {
   if (!RequiredAlignment.isZero()) {
     updateAlignment(RequiredAlignment);
     Size = Size.RoundUpToAlignment(Alignment);