]> granicus.if.org Git - psmisc/commitdiff
buildsys: signals.c depends on signames.h
authorCristian Morales Vega <cristian@samknows.com>
Sun, 20 May 2018 11:11:55 +0000 (21:11 +1000)
committerCraig Small <csmall@enc.com.au>
Sun, 20 May 2018 11:11:55 +0000 (21:11 +1000)
By explicitly specifying the dependency between signals.c and
signames.h.

BUILT_SOURCES only works with the standard targets, so if somebody tries
to build fuser directly he may end up with a build failure. What's
worse, he could do "make -j2 src/signames.h src/fuser" and he could end
up with a broken build using a only partially generated signames.h.

And that "somebody" was me when packaging killall in psmisc 22.21...
so it actually happens.

References:
 psmisc/psmisc!16

ChangeLog
Makefile.am

index 6d5eaaae7f7bf3c03ddb010faf95d9b7d91df50a..1627765fd4bb81d8213b855c4fe706e59d5b9d37 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,6 @@
 Changes in 23.2
 ===============
+       * buildsys: signals.c depends on signames.h !16
        * killall: look at all namespaces by default
        * killall: Fix -INT option parsing #11
        * killall: change to getopt_long without _only #12
index d32ddde5ff053e9bfa7b59ad9b3252a47b280fa1..d8c46192557415b747d1e7fb96a65f45e22ffa5e 100644 (file)
@@ -89,6 +89,8 @@ src/signames.h: src/signames.c Makefile
                grep '^{ 1,"HUP" },$$' $@ >/dev/null || \
                  { rm -f $@; exit 1; }
 
+src/signals.c: src/signames.h
+
 install-exec-hook:
                cd $(DESTDIR)$(bindir) && \
                        ( [ -h pstree.x11 ]  || $(LN_S) pstree pstree.x11)