patch 8.0.0344: unlet command leaks memory

Problem:    Unlet command leaks memory. (Nikolai Pavlov)
Solution:   Free the memory on error. (closes #1497)

diff --git a/src/eval.c b/src/eval.c
index 3cd73b6ea3ba45674afa959048c7da0d6944e749..b835af8e394664e26fd6520869867ad7773a4751 100644 (file)
--- a/src/eval.c
+++ b/src/eval.c
@@ -2079,7 +2079,10 @@ get_lval(
            }
            /* existing variable, need to check if it can be changed */
            else if (var_check_ro(lp->ll_di->di_flags, name, FALSE))
+           {
+               clear_tv(&var1);
                return NULL;
+           }
 
            if (len == -1)
                clear_tv(&var1);

diff --git a/src/testdir/test_unlet.vim b/src/testdir/test_unlet.vim
index 4c58785f2055c85d2069b20416afca057bdfc98a..c20b0beb7fcd43e52e2cf962285f50a618f37dcf 100644 (file)
--- a/src/testdir/test_unlet.vim
+++ b/src/testdir/test_unlet.vim
@@ -17,3 +17,7 @@ func Test_not_existing()
   unlet! does_not_exist
   call assert_fails('unlet does_not_exist', 'E108:')
 endfunc
+
+func Test_unlet_fails()
+  call assert_fails('unlet v:["count"]', 'E46:')
+endfunc

diff --git a/src/version.c b/src/version.c
index 5db4b111c3469e5c6fce52f90663eaabc4ea1533..7214854343cbac94b26349923b2bf534002e8e8b 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -764,6 +764,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    344,
 /**/
     343,
 /**/