]> granicus.if.org Git - postgresql/commitdiff
Silence warning about uninitialized 'ret' variable on some compilers.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 9 Jun 2017 18:50:35 +0000 (21:50 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 9 Jun 2017 18:50:35 +0000 (21:50 +0300)
If the compiler doesn't notice that the switch-statement handles all
possible values of the enum, it might complain that 'ret' is being used
without initialization. Jeff Janes reported that on gcc 4.4.7.

Discussion: https://www.postgresql.org/message-id/CAMkU=1x31RvP+cpooFbmc8K8nt-gNO8woGFhXcgQYYZ5ozYpFA@mail.gmail.com

src/interfaces/libpq/fe-connect.c

index c1dfa5eb9798fc5c1485600d68661aebc970ed0c..7a339d67ef4ee24137786e358a6a29422c073b78 100644 (file)
@@ -1668,6 +1668,7 @@ connectDBStart(PGconn *conn)
                snprintf(portstr, sizeof(portstr), "%d", thisport);
 
                /* Use pg_getaddrinfo_all() to resolve the address */
+               ret = 1;
                switch (ch->type)
                {
                        case CHT_HOST_NAME: