Fix an old corner-case bug in set_config_option: push_old_value has to be

called before, not after, calling the assign_hook if any.  This is because
push_old_value might fail (due to palloc out-of-memory), and in that case
there would be no stack entry to tell transaction abort to undo the GUC
assignment.  Of course the actual assignment to the GUC variable hasn't
happened yet --- but the assign_hook might have altered subsidiary state.
Without a stack entry we won't call it again to make it undo such actions.
So this is necessary to make the world safe for assign_hooks with side
effects.  Per a discussion a couple weeks ago with Magnus.

Back-patch to 8.0.  7.x did not have the problem because it did not have
allocatable stacks of GUC values.

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index aad13930f70d3aca2cc5e02ba46a9adbb7fcc464..099e4faed1d1cfea39662ff6f0389ffae1d8fa70 100644 (file)
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -10,7 +10,7 @@
  * Written by Peter Eisentraut <peter_e@gmx.net>.
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.299.2.3 2006/05/21 20:11:02 tgl Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.299.2.4 2008/05/26 18:54:50 tgl Exp $
  *
  *--------------------------------------------------------------------
  */
@@ -3716,6 +3716,10 @@ set_config_option(const char *name, const char *value,
                                        source = conf->gen.reset_source;
                                }
 
+                               /* Save old value to support transaction abort */
+                               if (changeVal && !makeDefault)
+                                       push_old_value(&conf->gen);
+
                                if (conf->assign_hook)
                                        if (!(*conf->assign_hook) (newval, changeVal, source))
                                        {
@@ -3728,9 +3732,6 @@ set_config_option(const char *name, const char *value,
 
                                if (changeVal || makeDefault)
                                {
-                                       /* Save old value to support transaction abort */
-                                       if (!makeDefault)
-                                               push_old_value(&conf->gen);
                                        if (changeVal)
                                        {
                                                *conf->variable = newval;
@@ -3800,6 +3801,10 @@ set_config_option(const char *name, const char *value,
                                        source = conf->gen.reset_source;
                                }
 
+                               /* Save old value to support transaction abort */
+                               if (changeVal && !makeDefault)
+                                       push_old_value(&conf->gen);
+
                                if (conf->assign_hook)
                                        if (!(*conf->assign_hook) (newval, changeVal, source))
                                        {
@@ -3812,9 +3817,6 @@ set_config_option(const char *name, const char *value,
 
                                if (changeVal || makeDefault)
                                {
-                                       /* Save old value to support transaction abort */
-                                       if (!makeDefault)
-                                               push_old_value(&conf->gen);
                                        if (changeVal)
                                        {
                                                *conf->variable = newval;
@@ -3884,6 +3886,10 @@ set_config_option(const char *name, const char *value,
                                        source = conf->gen.reset_source;
                                }
 
+                               /* Save old value to support transaction abort */
+                               if (changeVal && !makeDefault)
+                                       push_old_value(&conf->gen);
+
                                if (conf->assign_hook)
                                        if (!(*conf->assign_hook) (newval, changeVal, source))
                                        {
@@ -3896,9 +3902,6 @@ set_config_option(const char *name, const char *value,
 
                                if (changeVal || makeDefault)
                                {
-                                       /* Save old value to support transaction abort */
-                                       if (!makeDefault)
-                                               push_old_value(&conf->gen);
                                        if (changeVal)
                                        {
                                                *conf->variable = newval;
@@ -3972,6 +3975,10 @@ set_config_option(const char *name, const char *value,
                                        break;
                                }
 
+                               /* Save old value to support transaction abort */
+                               if (changeVal && !makeDefault)
+                                       push_old_value(&conf->gen);
+
                                if (conf->assign_hook)
                                {
                                        const char *hookresult;
@@ -4011,9 +4018,6 @@ set_config_option(const char *name, const char *value,
 
                                if (changeVal || makeDefault)
                                {
-                                       /* Save old value to support transaction abort */
-                                       if (!makeDefault)
-                                               push_old_value(&conf->gen);
                                        if (changeVal)
                                        {
                                                set_string_field(conf, conf->variable, newval);