]> granicus.if.org Git - sudo/commitdiff
closefrom() is overkill, the only extra fds are the ones we opened so
authorTodd C. Miller <Todd.Miller@courtesan.com>
Tue, 7 Sep 2004 17:31:54 +0000 (17:31 +0000)
committerTodd C. Miller <Todd.Miller@courtesan.com>
Tue, 7 Sep 2004 17:31:54 +0000 (17:31 +0000)
just close those in the child.

sudo_edit.c

index a5fefc4d265cc111e87fcdcbc076e97b33cb95c1..95a1e8bd0c8c75e31488b9c7ecfb2457117cad6a 100644 (file)
@@ -213,7 +213,8 @@ int sudo_edit(argc, argv)
        (void) sigaction(SIGINT, &saved_sa_int, NULL);
        (void) sigaction(SIGQUIT, &saved_sa_quit, NULL);
        (void) sigaction(SIGCHLD, &saved_sa_chld, NULL);
-       closefrom(STDERR_FILENO + 1);
+       for (i = 0; i < argc - 1; i++)
+           close(tf[i].tfd);
        set_perms(PERM_FULL_USER);
        execvp(nargv[0], nargv);
        warn("unable to execute %s", nargv[0]);