]> granicus.if.org Git - clang/commitdiff
Get rid of extra nesting when checking for invalid type,
authorFariborz Jahanian <fjahanian@apple.com>
Tue, 17 Aug 2010 23:50:37 +0000 (23:50 +0000)
committerFariborz Jahanian <fjahanian@apple.com>
Tue, 17 Aug 2010 23:50:37 +0000 (23:50 +0000)
per Doug's comment.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@111328 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Parse/ParseDecl.cpp

index ce0377020a4da1de4cc15e88f26585108af48882..928c2a9b5124d03d9fc7dfcf1efeb058631d5ca9 100644 (file)
@@ -2726,13 +2726,13 @@ void Parser::ParseDirectDeclarator(Declarator &D) {
     // scope when parsing the parenthesized declarator, then exited
     // the scope already. Re-enter the scope, if we need to.
     if (D.getCXXScopeSpec().isSet()) {
-      if (Actions.ShouldEnterDeclaratorScope(getCurScope(), D.getCXXScopeSpec()))
+      // If there was an error parsing parenthesized declarator, declarator
+      // scope may have been enterred before. Don't do it again.
+      if (!D.isInvalidType() &&
+          Actions.ShouldEnterDeclaratorScope(getCurScope(), D.getCXXScopeSpec()))
         // Change the declaration context for name lookup, until this function
         // is exited (and the declarator has been parsed).
-        // If there was an error parsing parenthesized declarator, declarator
-        // scope may have been enterred before. Don't do it again.
-        if (!D.isInvalidType())
-          DeclScopeObj.EnterDeclaratorScope();
+        DeclScopeObj.EnterDeclaratorScope();
     }
   } else if (D.mayOmitIdentifier()) {
     // This could be something simple like "int" (in which case the declarator