Rephrase a few comments for clarity.

I was confused by what "intended to be parallel serially" meant, until
Robert Haas and David G. Johnston explained it. Rephrase the comment to
make it more clear, using David's suggested wording.

Discussion: https://www.postgresql.org/message-id/1fec9022-41e8-e484-70ce-2179b08c2092%40iki.fi

diff --git a/src/backend/executor/nodeIndexonlyscan.c b/src/backend/executor/nodeIndexonlyscan.c
index 3a02a996214985f6c067407b50fb1419988117fd..8c32a74d39ea1856bcdaffdbd0302436b3efcbf4 100644 (file)
--- a/src/backend/executor/nodeIndexonlyscan.c
+++ b/src/backend/executor/nodeIndexonlyscan.c
@@ -84,8 +84,8 @@ IndexOnlyNext(IndexOnlyScanState *node)
        {
                /*
                 * We reach here if the index only scan is not parallel, or if we're
-                * executing a index only scan that was intended to be parallel
-                * serially.
+                * serially executing an index only scan that was planned to be
+                * parallel.
                 */
                scandesc = index_beginscan(node->ss.ss_currentRelation,
                                                                   node->ioss_RelationDesc,

diff --git a/src/backend/executor/nodeIndexscan.c b/src/backend/executor/nodeIndexscan.c
index d6012192a149127f742ce89b0080daff01bb1399..10891bc3f46d51d0ac0e5c5dcba7bd99933d03e2 100644 (file)
--- a/src/backend/executor/nodeIndexscan.c
+++ b/src/backend/executor/nodeIndexscan.c
@@ -108,7 +108,7 @@ IndexNext(IndexScanState *node)
        {
                /*
                 * We reach here if the index scan is not parallel, or if we're
-                * executing a index scan that was intended to be parallel serially.
+                * serially executing an index scan that was planned to be parallel.
                 */
                scandesc = index_beginscan(node->ss.ss_currentRelation,
                                                                   node->iss_RelationDesc,
@@ -214,7 +214,7 @@ IndexNextWithReorder(IndexScanState *node)
        {
                /*
                 * We reach here if the index scan is not parallel, or if we're
-                * executing a index scan that was intended to be parallel serially.
+                * serially executing an index scan that was planned to be parallel.
                 */
                scandesc = index_beginscan(node->ss.ss_currentRelation,
                                                                   node->iss_RelationDesc,

diff --git a/src/backend/executor/nodeSeqscan.c b/src/backend/executor/nodeSeqscan.c
index 9db368922a303315d65df932cbcd146d9c76cf6d..c7849de6bca69587484266d6e487dfc30126f9e2 100644 (file)
--- a/src/backend/executor/nodeSeqscan.c
+++ b/src/backend/executor/nodeSeqscan.c
@@ -65,8 +65,8 @@ SeqNext(SeqScanState *node)
        if (scandesc == NULL)
        {
                /*
-                * We reach here if the scan is not parallel, or if we're executing a
-                * scan that was intended to be parallel serially.
+                * We reach here if the scan is not parallel, or if we're serially
+                * executing a scan that was planned to be parallel.
                 */
                scandesc = heap_beginscan(node->ss.ss_currentRelation,
                                                                  estate->es_snapshot,