core: Avoid a compiler warning when NO_LINGCLOSE is used (-Wunreachable-code).
Also, check c->aborted before apr_socket_shutdown() because it is set earlier,
and there is no point in calling shutdown() before close().
mod_ldap: fix format warnings.
Submitted by: ylavic
Reviewed by: jailletc36, jim, ylavic
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@
1832491 13f79535-47bb-0310-9956-
ffa450edef68
"<td nowrap>%ld</td>"
"<td nowrap>%ld</td>"
"<td nowrap>%ld</td>"
- "<td nowrap>%ld</td>"
+ "<td nowrap>%" APR_TIME_T_FMT "</td>"
"<td nowrap>%ld</td>"
"<td nowrap>%s</td>"
"</tr>",
cache_node->size,
cache_node->maxentries,
cache_node->numentries,
- cache_node->ttl / APR_USEC_PER_SEC,
+ apr_time_sec(cache_node->ttl),
cache_node->fullmark,
date_str);
}
"</tr>\n"
"<tr>\n"
"<td bgcolor='#000000'><font size='-1' face='Arial,Helvetica' color='#ffffff'><b>TTL (sec):</b></font></td>"
- "<td bgcolor='#ffffff'><font size='-1' face='Arial,Helvetica' color='#000000'><b>%ld</b></font></td>"
+ "<td bgcolor='#ffffff'><font size='-1' face='Arial,Helvetica' color='#000000'><b>%" APR_TIME_T_FMT "</b></font></td>"
"</tr>\n"
"<tr>\n"
"<td bgcolor='#000000'><font size='-1' face='Arial,Helvetica' color='#ffffff'><b>Full Mark:</b></font></td>"
util_ldap_cache->size,
util_ldap_cache->maxentries,
util_ldap_cache->numentries,
- util_ldap_cache->ttl / APR_USEC_PER_SEC,
+ apr_time_sec(util_ldap_cache->ttl),
util_ldap_cache->fullmark,
date_str);
return 1;
}
-#ifdef NO_LINGCLOSE
- ap_flush_conn(c); /* just close it */
- apr_socket_close(csd);
- return 1;
-#endif
-
/* Close the connection, being careful to send out whatever is still
* in our buffers. If possible, try to avoid a hard close until the
* client has ACKed our FIN and/or has stopped sending us data.
/* Send any leftover data to the client, but never try to again */
ap_flush_conn(c);
- if (c->aborted) {
- apr_socket_close(csd);
- return 1;
- }
-
+#ifdef NO_LINGCLOSE
+ apr_socket_close(csd);
+ return 1;
+#else
/* Shut down the socket for write, which will send a FIN
* to the peer.
*/
- if (apr_socket_shutdown(csd, APR_SHUTDOWN_WRITE) != APR_SUCCESS
- || c->aborted) {
+ if (c->aborted
+ || apr_socket_shutdown(csd, APR_SHUTDOWN_WRITE) != APR_SUCCESS) {
apr_socket_close(csd);
return 1;
}
-
return 0;
+#endif
}
AP_DECLARE(void) ap_lingering_close(conn_rec *c)