]> granicus.if.org Git - taglib/commitdiff
Revert "Fix opening of read-only files on Windows"
authorLukáš Lalinský <lalinsky@gmail.com>
Tue, 20 Nov 2012 17:34:51 +0000 (18:34 +0100)
committerLukáš Lalinský <lalinsky@gmail.com>
Tue, 20 Nov 2012 17:34:51 +0000 (18:34 +0100)
This reverts commit ade8dc1a218e43c3909c4eede58f4e28e09da73a.

taglib/toolkit/tfilestream.cpp

index 6077d70569f533220502e9026ea295e64fe6150b..5225202344874289ba5bc7a84cc92bff243cab1f 100644 (file)
@@ -58,16 +58,10 @@ namespace {
   {
     DWORD access = readOnly ? GENERIC_READ : (GENERIC_READ | GENERIC_WRITE);
 
-    HANDLE handle;
     if(wcslen(path) > 0)
-      handle = CreateFileW(path, access, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL);
+      return CreateFileW(path, access, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL);
     else
-      handle = CreateFileA(path, access, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL);
-
-    if(handle == INVALID_HANDLE_VALUE)
-      handle = NULL;
-
-    return handle;
+      return CreateFileA(path, access, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL);
   }
 
   size_t fread(void *ptr, size_t size, size_t nmemb, HANDLE stream)