]> granicus.if.org Git - python/commitdiff
Issue #25081: Makes Back button in installer go back to upgrade page when upgrading.
authorSteve Dower <steve.dower@microsoft.com>
Tue, 22 Sep 2015 23:36:33 +0000 (16:36 -0700)
committerSteve Dower <steve.dower@microsoft.com>
Tue, 22 Sep 2015 23:36:33 +0000 (16:36 -0700)
Misc/NEWS
Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp

index 5440470ba18a3a4937a8adfdcbb0b7e4c4da8ced..2ed6491172434ee5f2c649f0af8264bf7d1601d6 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -150,6 +150,9 @@ Build
 Windows
 -------
 
+- Issue #25081: Makes Back button in installer go back to upgrade page when
+  upgrading.
+
 - Issue #25091: Increases font size of the installer.
 
 - Issue #25126: Clarifies that the non-web installer will download some
index 35ed2fe73bef06124d3bfa1c4d7fac81229c2059..99884e4c9aa9a0cb4574ef5e57b346da44d9f7cd 100644 (file)
@@ -323,6 +323,8 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
             SavePageSettings();
             if (_modifying) {
                 GoToPage(PAGE_MODIFY);
+            } else if (_upgrading) {
+                GoToPage(PAGE_UPGRADE);
             } else {
                 GoToPage(PAGE_INSTALL);
             }
@@ -2524,6 +2526,7 @@ private:
                     case BOOTSTRAPPER_ACTION_INSTALL:
                         if (_upgradingOldVersion) {
                             _installPage = PAGE_UPGRADE;
+                            _upgrading = TRUE;
                         } else if (SUCCEEDED(BalGetNumericVariable(L"SimpleInstall", &simple)) && simple) {
                             _installPage = PAGE_SIMPLE_INSTALL;
                         } else {
@@ -3029,6 +3032,7 @@ public:
         _suppressDowngradeFailure = FALSE;
         _suppressRepair = FALSE;
         _modifying = FALSE;
+        _upgrading = FALSE;
 
         _overridableVariables = nullptr;
         _taskbarList = nullptr;
@@ -3113,6 +3117,7 @@ private:
     BOOL _suppressDowngradeFailure;
     BOOL _suppressRepair;
     BOOL _modifying;
+    BOOL _upgrading;
 
     int _crtInstalledToken;