Use pg_dump's --quote-all-identifiers option in pg_upgrade.

This helps guard against changes in the set of reserved keywords from
one version to another.  In theory it should only be an issue if we
de-reserve a keyword in a newer release, since that can create the type
of problem shown in bug #8128.

Back-patch to 9.1 where the --quote-all-identifiers option was added.

diff --git a/contrib/pg_upgrade/dump.c b/contrib/pg_upgrade/dump.c
index 148dfb70c1805c0aa6ff3a961623bacbcf5273d4..38169e6f90a77fa0051a749fcadc1651a11f020a 100644 (file)
--- a/contrib/pg_upgrade/dump.c
+++ b/contrib/pg_upgrade/dump.c
@@ -24,7 +24,8 @@ generate_old_dump(void)
         * restores the frozenid's for databases and relations.
         */
        exec_prog(UTILITY_LOG_FILE, NULL, true,
-                         "\"%s/pg_dumpall\" %s --schema-only --binary-upgrade %s -f %s",
+                         "\"%s/pg_dumpall\" %s --schema-only --quote-all-identifiers "
+                         "--binary-upgrade %s -f %s",
                          new_cluster.bindir, cluster_conn_opts(&old_cluster),
                          log_opts.verbose ? "--verbose" : "",
                          ALL_DUMP_FILE);