Remove special case for xmin == xmax in HeapTupleSatisfiesVacuum().

VACUUM was willing to remove a committed-dead tuple immediately if it was
deleted by the same transaction that inserted it.  The idea is that such a
tuple could never have been visible to any other transaction, so we don't
need to keep it around to satisfy MVCC snapshots.  However, there was
already an exception for tuples that are part of an update chain, and this
exception created a problem: we might remove TOAST tuples (which are never
part of an update chain) while their parent tuple stayed around (if it was
part of an update chain).  This didn't pose a problem for most things,
since the parent tuple is indeed dead: no snapshot will ever consider it
visible.  But MVCC-safe CLUSTER had a problem, since it will try to copy
RECENTLY_DEAD tuples to the new table.  It then has to copy their TOAST
data too, and would fail if VACUUM had already removed the toast tuples.

Easiest fix is to get rid of the special case for xmin == xmax.  This may
delay reclaiming dead space for a little bit in some cases, but it's by far
the most reliable way to fix the issue.

Per bug #5998 from Mark Reid.  Back-patch to 8.3, which is the oldest
version with MVCC-safe CLUSTER.

diff --git a/src/backend/utils/time/tqual.c b/src/backend/utils/time/tqual.c
index 2fd32e05d14725631dff80b4f5568b46d63cf0cc..d81ee7de062500714a8cb960add31ba40e8794c9 100644 (file)
--- a/src/backend/utils/time/tqual.c
+++ b/src/backend/utils/time/tqual.c
@@ -1217,27 +1217,11 @@ HeapTupleSatisfiesVacuum(HeapTupleHeader tuple, TransactionId OldestXmin,
        }
 
        /*
-        * Deleter committed, but check special cases.
+        * Deleter committed, but perhaps it was recent enough that some open
+        * transactions could still see the tuple.
         */
-
-       if (TransactionIdEquals(HeapTupleHeaderGetXmin(tuple),
-                                                       HeapTupleHeaderGetXmax(tuple)))
-       {
-               /*
-                * Inserter also deleted it, so it was never visible to anyone else.
-                * However, we can only remove it early if it's not an updated tuple;
-                * else its parent tuple is linking to it via t_ctid, and this tuple
-                * mustn't go away before the parent does.
-                */
-               if (!(tuple->t_infomask & HEAP_UPDATED))
-                       return HEAPTUPLE_DEAD;
-       }
-
        if (!TransactionIdPrecedes(HeapTupleHeaderGetXmax(tuple), OldestXmin))
-       {
-               /* deleting xact is too recent, tuple could still be visible */
                return HEAPTUPLE_RECENTLY_DEAD;
-       }
 
        /* Otherwise, it's dead and removable */
        return HEAPTUPLE_DEAD;