Fix #78241: touch() does not handle dates after 2038 in PHP 64-bit

`time_t` defaults to `_time64` (which is 64bit signed) even on x86, but
`Int32x32To64()` truncates it to signed 32bit.  We replace the macro
with the "manual" calculation.

diff --git a/NEWS b/NEWS
index 078d61c1eb8bfc47c4ec1c268d87e7ba877bb01e..4c05f42773c05d4fe92c1c9cfbd5e47e927b0767 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -21,6 +21,9 @@ PHP                                                                        NEWS
   . Fixed #78189 (file cache strips last character of uname hash). (cmb)
   . Fixed #78202 (Opcache stats for cache hits are capped at 32bit NUM). (cmb)
 
+- Standard:
+  . Fixed #78241 (touch() does not handle dates after 2038 in PHP 64-bit). (cmb)
+
 27 Jun 2019, PHP 7.2.20
 
 - Core:

diff --git a/TSRM/tsrm_win32.c b/TSRM/tsrm_win32.c
index ca121de057edc68193fe8e0b7e5c24c40a633383..34b0676461168e3dc817583efbd54f7b858935e7 100644 (file)
--- a/TSRM/tsrm_win32.c
+++ b/TSRM/tsrm_win32.c
@@ -804,7 +804,7 @@ static zend_always_inline void UnixTimeToFileTime(time_t t, LPFILETIME pft) /* {
        // Note that LONGLONG is a 64-bit value
        LONGLONG ll;
 
-       ll = Int32x32To64(t, 10000000) + 116444736000000000;
+       ll = t * 10000000 + 116444736000000000;
        pft->dwLowDateTime = (DWORD)ll;
        pft->dwHighDateTime = ll >> 32;
 }

diff --git a/ext/standard/tests/file/bug78241.phpt b/ext/standard/tests/file/bug78241.phpt
new file mode 100644 (file)
index 0000000..99fed8a
--- /dev/null
+++ b/ext/standard/tests/file/bug78241.phpt
@@ -0,0 +1,33 @@
+--TEST--
+Bug #78241 (touch() does not handle dates after 2038 in PHP 64-bit)
+--SKIPIF--
+<?php
+if (substr(PHP_OS, 0, 3) != 'WIN') die('skip this test is for Windows platforms only');
+if (PHP_INT_SIZE != 8) die('skip this test is for 64bit platforms only');
+?>
+--INI--
+date.timezone=UTC
+--FILE--
+<?php
+$filename = __DIR__ . '/bug78241.txt';
+for ($i = 2037; $i <= 2040; $i++) {
+  $t = mktime(1, 1 , 1, 1, 1, $i);
+  echo 'Date: '.date('D, d M Y H:i:s', $t), PHP_EOL;
+  touch($filename, $t);
+  clearstatcache(true, $filename);
+  $file = filemtime($filename);
+  echo 'File: '.date('D, d M Y H:i:s', $file), PHP_EOL, PHP_EOL;
+}
+?>
+--EXPECT--
+Date: Thu, 01 Jan 2037 01:01:01
+File: Thu, 01 Jan 2037 01:01:01
+
+Date: Fri, 01 Jan 2038 01:01:01
+File: Fri, 01 Jan 2038 01:01:01
+
+Date: Sat, 01 Jan 2039 01:01:01
+File: Sat, 01 Jan 2039 01:01:01
+
+Date: Sun, 01 Jan 2040 01:01:01
+File: Sun, 01 Jan 2040 01:01:01