]> granicus.if.org Git - graphviz/commitdiff
expr: [nfc] remove unnecessary parens and dereference of 'setf'
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 26 Feb 2022 19:01:57 +0000 (11:01 -0800)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Sun, 27 Feb 2022 22:57:01 +0000 (14:57 -0800)
The C compiler knows how to dereference and call through a function pointer
without needing this manual instruction.

lib/expr/exeval.c

index ac27d3820a56defaf4ea2876aa3bcbbcfff913d2..366153f4115f148e9858f64c098e71e44014e5a6 100644 (file)
@@ -1209,7 +1209,9 @@ eval(Expr_t* ex, Exnode_t* expr, void* env)
                                locv = getdyn(ex, x->data.variable.dyna, env, &assoc);
                                x->data.variable.dyna->data.variable.dyna->data.constant.value = locv;
                        }
-                       if ((*ex->disc->setf)(ex, x, x->data.variable.symbol, x->data.variable.reference, env, (int)i.integer, v, ex->disc) < 0)
+                       if (ex->disc->setf(ex, x, x->data.variable.symbol,
+                                          x->data.variable.reference, env, (int)i.integer, v,
+                                          ex->disc) < 0)
                                exerror("%s: cannot set value", x->data.variable.symbol->name);
                }
                if (expr->subop == PRE)