Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable.

Many automated test suites call pg_ctl.  Buildfarm members axolotl,
hornet, mandrill, shearwater, sungazer and tern have failed when server
shutdown took longer than the pg_ctl default 60s timeout.  This addition
permits slow hosts to easily raise the timeout without us editing a
--timeout argument into every test suite pg_ctl call.  Back-patch to 9.1
(all supported versions) for the sake of automated testing.

Reviewed by Tom Lane.

diff --git a/doc/src/sgml/ref/pg_ctl-ref.sgml b/doc/src/sgml/ref/pg_ctl-ref.sgml
index 52bcf5e81538ee8085febae0c9f615a7ce3a9248..f67297479d62cdaa861e8d21c6eed8efb1ca8cb9 100644 (file)
--- a/doc/src/sgml/ref/pg_ctl-ref.sgml
+++ b/doc/src/sgml/ref/pg_ctl-ref.sgml
@@ -361,7 +361,9 @@ PostgreSQL documentation
       <listitem>
        <para>
         The maximum number of seconds to wait when waiting for startup or
-        shutdown to complete.  The default is 60 seconds.
+        shutdown to complete.  Defaults to the value of the
+        <envar>PGCTLTIMEOUT</> environment variable or, if not set, to 60
+        seconds.
        </para>
       </listitem>
      </varlistentry>
@@ -469,6 +471,17 @@ PostgreSQL documentation
   <title>Environment</title>
 
   <variablelist>
+   <varlistentry>
+    <term><envar>PGCTLTIMEOUT</envar></term>
+
+    <listitem>
+     <para>
+      Default limit on the number of seconds to wait when waiting for startup
+      or shutdown to complete.  If not set, the default is 60 seconds.
+     </para>
+    </listitem>
+   </varlistentry>
+
    <varlistentry>
     <term><envar>PGDATA</envar></term>
 

diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 765fca81f47f8b46ba916336b3c4277e6a003317..0d68ec93df9b0c3ee6f3fe2135294e9c977dac22 100644 (file)
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -79,6 +79,7 @@ typedef enum
 static bool do_wait = false;
 static bool wait_set = false;
 static int     wait_seconds = DEFAULT_WAIT;
+static bool wait_seconds_arg = false;
 static bool silent_mode = false;
 static ShutdownMode shutdown_mode = SMART_MODE;
 static int     sig = SIGTERM;          /* default */
@@ -1456,7 +1457,8 @@ pgwin32_CommandLine(bool registration)
        if (registration && do_wait)
                appendPQExpBuffer(cmdLine, " -w");
 
-       if (registration && wait_seconds != DEFAULT_WAIT)
+       /* Don't propagate a value from an environment variable. */
+       if (registration && wait_seconds_arg && wait_seconds != DEFAULT_WAIT)
                appendPQExpBuffer(cmdLine, " -t %d", wait_seconds);
 
        if (registration && silent_mode)
@@ -2291,6 +2293,7 @@ main(int argc, char **argv)
                {NULL, 0, NULL, 0}
        };
 
+       char       *env_wait;
        int                     option_index;
        int                     c;
        pgpid_t         killproc = 0;
@@ -2341,6 +2344,10 @@ main(int argc, char **argv)
        }
 #endif
 
+       env_wait = getenv("PGCTLTIMEOUT");
+       if (env_wait != NULL)
+               wait_seconds = atoi(env_wait);
+
        /*
         * 'Action' can be before or after args so loop over both. Some
         * getopt_long() implementations will reorder argv[] to place all flags
@@ -2406,6 +2413,7 @@ main(int argc, char **argv)
                                        break;
                                case 't':
                                        wait_seconds = atoi(optarg);
+                                       wait_seconds_arg = true;
                                        break;
                                case 'U':
                                        if (strchr(optarg, '\\'))