]> granicus.if.org Git - clang/commitdiff
Add explicit dependency on clangSerialization for a bunch of components to fix -DBUIL...
authorFangrui Song <maskray@google.com>
Wed, 12 Dec 2018 08:02:18 +0000 (08:02 +0000)
committerFangrui Song <maskray@google.com>
Wed, 12 Dec 2018 08:02:18 +0000 (08:02 +0000)
This is a more thorough fix of rC348911.
The story about -DBUILD_SHARED_LIBS=on build after rC348907 (Move PCHContainerOperations from Frontend to Serialization) is:

1. libclangSerialization.so defines PCHContainerReader dtor, ...
2. clangFrontend and clangTooling define classes inheriting from PCHContainerReader, thus their DSOs have undefined references on PCHContainerReader dtor
3. Components depending on either clangFrontend or clangTooling cannot be linked unless they have explicit dependency on clangSerialization due to the default linker option -z defs. The explicit dependency could be avoided if libclang{Frontend,Tooling}.so had these undefined references.

This patch adds the explicit dependency on clangSerialization to make them build.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@348915 91177308-0d34-0410-b5e6-96231b3b80d8

22 files changed:
lib/Tooling/CMakeLists.txt
tools/arcmt-test/CMakeLists.txt
tools/clang-check/CMakeLists.txt
tools/clang-diff/CMakeLists.txt
tools/clang-func-mapping/CMakeLists.txt
tools/clang-import-test/CMakeLists.txt
tools/clang-refactor/CMakeLists.txt
tools/clang-rename/CMakeLists.txt
tools/driver/CMakeLists.txt
tools/libclang/CMakeLists.txt
unittests/AST/CMakeLists.txt
unittests/ASTMatchers/CMakeLists.txt
unittests/ASTMatchers/Dynamic/CMakeLists.txt
unittests/Analysis/CMakeLists.txt
unittests/CodeGen/CMakeLists.txt
unittests/CrossTU/CMakeLists.txt
unittests/Frontend/CMakeLists.txt
unittests/Index/CMakeLists.txt
unittests/Rename/CMakeLists.txt
unittests/Sema/CMakeLists.txt
unittests/StaticAnalyzer/CMakeLists.txt
unittests/Tooling/CMakeLists.txt

index 031d8b51dec46f21502b633dbb579c3f4150ebf2..4b671e299ab79a6a8d523b3a85721c5cada374dc 100644 (file)
@@ -35,5 +35,6 @@ add_clang_library(clangTooling
   clangFrontend
   clangLex
   clangRewrite
+  clangSerialization
   clangToolingCore
   )
index 2b456be2fcdd7970501f3dafa4ed97a6b972f0ba..c4c1463241b489eddc2cbeab978e9eab736ae708 100644 (file)
@@ -12,4 +12,5 @@ target_link_libraries(arcmt-test
   clangBasic
   clangFrontend
   clangLex
+  clangSerialization
   )
index c5ace26c2914ed9123a1c9361094b9c617cda4ee..b837b0a0a5d9dbdc8cc8cd0d7b8038a734f4f0f6 100644 (file)
@@ -15,6 +15,7 @@ target_link_libraries(clang-check
   clangDriver
   clangFrontend
   clangRewriteFrontend
+  clangSerialization
   clangStaticAnalyzerFrontend
   clangTooling
   )
index 09bebf2cb6e5fe6935ac5f04555cdecf3bac9275..ab9a5bbbe916458dcfbc7061ce87f88bd83fb988 100644 (file)
@@ -10,6 +10,7 @@ target_link_libraries(clang-diff
   PRIVATE
   clangBasic
   clangFrontend
+  clangSerialization
   clangTooling
   clangToolingASTDiff
   )
index 2fc6aba9524896349ad12b5808320387d79efba9..3544009a45d8bf620f16ca77abfdaf61d527bb0c 100644 (file)
@@ -13,6 +13,7 @@ target_link_libraries(clang-func-mapping
   clangBasic
   clangCrossTU
   clangFrontend
+  clangSerialization
   clangTooling
   )
 
index dfccfe2304bd9748a8596bd6e570ec662d52b549..ee1bdab64a5da48bdad41609375253d8a3171149 100644 (file)
@@ -21,6 +21,7 @@ set(CLANG_IMPORT_TEST_LIB_DEPS
   clangFrontend
   clangLex
   clangParse
+  clangSerialization
   )
 
 target_link_libraries(clang-import-test
index b435744ca4bdabb0080c0c56e1c1cca4d9cf206e..48206e7306580b1fb249eda90e1e0a5bee9ce450 100644 (file)
@@ -16,6 +16,7 @@ target_link_libraries(clang-refactor
   clangFrontend
   clangLex
   clangRewrite
+  clangSerialization
   clangTooling
   clangToolingCore
   clangToolingRefactor
index 3b3ab1540a80730cfaabe55c05a8212f878081f7..45cbd763425c077a59902a2d1cbeed840bab5b1e 100644 (file)
@@ -12,6 +12,7 @@ target_link_libraries(clang-rename
   clangBasic
   clangFrontend
   clangRewrite
+  clangSerialization
   clangTooling
   clangToolingCore
   clangToolingRefactor
index 15b0519e4111bfbff95de9e0328fc29770ca9d9a..89a3aa3ced85169b454bec5f31d0a4c272433fad 100644 (file)
@@ -46,6 +46,7 @@ target_link_libraries(clang
   clangDriver
   clangFrontend
   clangFrontendTool
+  clangSerialization
   )
 
 if(WIN32 AND NOT CYGWIN)
index 729d5560b658292e1b8652c8e1e36712c53dce6a..32333b011ad1315e199f3dc315a635f5702e4338 100644 (file)
@@ -40,6 +40,7 @@ set(LIBS
   clangIndex
   clangLex
   clangSema
+  clangSerialization
   clangTooling
 )
 
index 776e3dcf6df0a3c0dfb14ff7b1ad14db9cd26f88..6621ce681bc40879583c68561a83325d68c01a94 100644 (file)
@@ -28,5 +28,6 @@ target_link_libraries(ASTTests
   clangASTMatchers
   clangBasic
   clangFrontend
+  clangSerialization
   clangTooling
   )
index ae1aecf503cc05b975b5d6c923d8f1ba9fe1f741..4e44c795f894ebeb763f3859c2f5d673554e2644 100644 (file)
@@ -24,6 +24,7 @@ target_link_libraries(ASTMatchersTests
   clangASTMatchers
   clangBasic
   clangFrontend
+  clangSerialization
   clangTooling
   )
 
index 0fd96e97cff0c4f99e417a314c2c52a5e3598460..07742caef658f8ed207831f0b25213dec45c5e28 100644 (file)
@@ -15,5 +15,6 @@ target_link_libraries(DynamicASTMatchersTests
   clangBasic
   clangDynamicASTMatchers
   clangFrontend
+  clangSerialization
   clangTooling
   )
index 2291e6a8dd18aba1c649edf3e9e51865754a34ff..c760ae2d82b7e83ee3fdc8150f0ca26d53351024 100644 (file)
@@ -15,5 +15,6 @@ target_link_libraries(ClangAnalysisTests
   clangASTMatchers
   clangBasic
   clangFrontend
+  clangSerialization
   clangTooling
   )
index 856dbce08ea9b0945d6e864a219ab319bf802af5..e4e7588a93275446a3ba1976d6ba90c94080806b 100644 (file)
@@ -18,4 +18,5 @@ target_link_libraries(ClangCodeGenTests
   clangFrontend
   clangLex
   clangParse
+  clangSerialization
   )
index 652d91612fb4dd0f035cb50a4606ced7d18545cc..73047b739a4ac68942aad3a825ef4e8223e44424 100644 (file)
@@ -13,5 +13,6 @@ target_link_libraries(CrossTUTests
   clangBasic
   clangCrossTU
   clangFrontend
+  clangSerialization
   clangTooling
   )
index e36570a88bffcd15bbf3b98b5e21cb4180acbc0d..c7851bb394eee5023218a71bd519694d853221ca 100644 (file)
@@ -21,4 +21,5 @@ target_link_libraries(FrontendTests
   clangSema
   clangCodeGen
   clangFrontendTool
+  clangSerialization
   )
index 32c36504c509db0b344449f06050ba72ec3b6fb0..2756fad906a3a25ecdc9694849df1ef09253c6ce 100644 (file)
@@ -14,5 +14,6 @@ target_link_libraries(IndexTests
   clangFrontend
   clangIndex
   clangLex
+  clangSerialization
   clangTooling
   )
index b625a7a691fbb39d7b5750b662fec5e73bd3834b..f91021dd15457a7077dbff3ff95a250ed1e852ff 100644 (file)
@@ -21,6 +21,7 @@ target_link_libraries(ClangRenameTests
   clangFormat
   clangFrontend
   clangRewrite
+  clangSerialization
   clangTooling
   clangToolingCore
   clangToolingRefactor
index 45460f1e0f6c55b62c2b54e7cb2e3c21f6e84b0a..78601046dcd44606833d37bfed0e2a8ab8176ec0 100644 (file)
@@ -14,5 +14,6 @@ target_link_libraries(SemaTests
   clangFrontend
   clangParse
   clangSema
+  clangSerialization
   clangTooling
   )
index ff041452dfd42f843b17494a8e39b874509ae8bb..3036dec1676a3879c3a68fce6c8c36e6b24e968f 100644 (file)
@@ -12,6 +12,7 @@ target_link_libraries(StaticAnalysisTests
   clangBasic
   clangAnalysis
   clangFrontend
+  clangSerialization
   clangStaticAnalyzerCore
   clangStaticAnalyzerFrontend
   clangTooling
index 823971a242ff6d46099421d70c66de5c276df443..7619c7fb2348592f8c63e32f77acb236f4b4fab5 100644 (file)
@@ -61,6 +61,7 @@ target_link_libraries(ToolingTests
   clangFrontend
   clangLex
   clangRewrite
+  clangSerialization
   clangTooling
   clangToolingCore
   clangToolingInclusions