Security Fix broken! Destroyed Basic auth. Blame: me

4.3.x not affected

diff --git a/sapi/apache/mod_php5.c b/sapi/apache/mod_php5.c
index d477a141a743ff463acc9b389cffe3724f0ff943..4aac2d2862447b61ebfd227e307934dcf913c7ca 100644 (file)
--- a/sapi/apache/mod_php5.c
+++ b/sapi/apache/mod_php5.c
@@ -485,7 +485,7 @@ static void init_request_info(TSRMLS_D)
                tmp = uudecode(r->pool, authorization);
                SG(request_info).auth_user = NULL;
                tmp_user = getword_nulls_nc(r->pool, &tmp, ':');
-               if (SG(request_info).auth_user) {
+               if (tmp_user) {
                        r->connection->user = pstrdup(r->connection->pool, tmp_user);
                        r->connection->ap_auth_type = "Basic";
                        SG(request_info).auth_user = estrdup(tmp_user);