When reloading postgresql.conf, log what parameters actually changed

diff --git a/src/backend/utils/misc/guc-file.l b/src/backend/utils/misc/guc-file.l
index ad52fb138a359e075c641c2b695e82333d0a7f90..3bd466b240cd503b07df98a1a52845cd0f63f039 100644 (file)
--- a/src/backend/utils/misc/guc-file.l
+++ b/src/backend/utils/misc/guc-file.l
@@ -4,7 +4,7 @@
  *
  * Copyright (c) 2000-2009, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.59 2009/04/09 14:21:02 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.60 2009/09/17 20:54:03 petere Exp $
  */
 
 %{
@@ -283,6 +283,10 @@ ProcessConfigFile(GucContext context)
                /* Now we can re-apply the wired-in default */
                set_config_option(gconf->name, NULL, context, PGC_S_DEFAULT,
                                                  GUC_ACTION_SET, true);
+               if (context == PGC_SIGHUP)
+                       ereport(elevel,
+                                       (errmsg("parameter \"%s\" removed from configuration file, reset to default",
+                                                       gconf->name)));
        }
 
        /*
@@ -309,9 +313,18 @@ ProcessConfigFile(GucContext context)
        /* If we got here all the options checked out okay, so apply them. */
        for (item = head; item; item = item->next)
        {
+               char *pre_value = NULL;
+
+               if (context == PGC_SIGHUP)
+                       pre_value = pstrdup(GetConfigOption(item->name));
+
                if (set_config_option(item->name, item->value, context,
                                                                 PGC_S_FILE, GUC_ACTION_SET, true))
                {
+                       if (pre_value && strcmp(pre_value, GetConfigOption(item->name)) != 0)
+                               ereport(elevel,
+                                               (errmsg("parameter \"%s\" changed to \"%s\"",
+                                                               item->name, item->value)));
                        set_config_sourcefile(item->name, item->filename,
                                                                  item->sourceline);
                }