Add parser finalization check for undefined symbols.

svn path=/trunk/yasm/; revision=287

diff --git a/frontends/yasm/yasm.c b/frontends/yasm/yasm.c
index f08c483f118228e3387f58bc977adb1e1d085b7a..edd8f3ed4590423c5e9564e5415ccc8fc09f04f6 100644 (file)
--- a/frontends/yasm/yasm.c
+++ b/frontends/yasm/yasm.c
@@ -135,6 +135,7 @@ main(int argc, char *argv[])
     printf("\n***Symbol Table***\n");
     symrec_foreach((int (*) (symrec *))symrec_print);
 
+    symrec_parser_finalize();
     sections_parser_finalize(sections);
 
     printf("Post-parser-finalization:\n");

diff --git a/libyasm/symrec.c b/libyasm/symrec.c
index a2700ffeb565244e5d603f82a6188d81bad91ad7..46db876e44fd806eb7fd503502011acb3f20b813 100644 (file)
--- a/libyasm/symrec.c
+++ b/libyasm/symrec.c
@@ -243,6 +243,26 @@ symrec_get_equ(const symrec *sym)
     return (const expr *)NULL;
 }
 
+static int
+symrec_parser_finalize_checksym(symrec *sym)
+{
+    /* error if a symbol is used but never defined */
+    if ((sym->status & SYM_USED) && !(sym->status & SYM_DEFINED)) {
+       ErrorAt(sym->filename, sym->line,
+               _("undefined symbol `%s' (first use)"), sym->name);
+       ErrorAt(sym->filename, sym->line,
+               _("(Each undefined symbol is reported only once.)"));
+       return 0;
+    } else
+       return 1;
+}
+
+void
+symrec_parser_finalize(void)
+{
+    symrec_foreach(symrec_parser_finalize_checksym);
+}
+
 void
 symrec_print(const symrec *sym)
 {

diff --git a/libyasm/symrec.h b/libyasm/symrec.h
index e87e7f193c2ad0249b5b4b70d102acb12f51eace..60ed516e79eeee85db812266f2e8ed95e6a907e9 100644 (file)
--- a/libyasm/symrec.h
+++ b/libyasm/symrec.h
@@ -72,5 +72,7 @@ const expr *symrec_get_equ(const symrec *sym);
 
 int symrec_foreach(int (*func) (symrec *sym));
 
+void symrec_parser_finalize(void);
+
 void symrec_print(const symrec *sym);
 #endif

diff --git a/src/main.c b/src/main.c
index f08c483f118228e3387f58bc977adb1e1d085b7a..edd8f3ed4590423c5e9564e5415ccc8fc09f04f6 100644 (file)
--- a/src/main.c
+++ b/src/main.c
@@ -135,6 +135,7 @@ main(int argc, char *argv[])
     printf("\n***Symbol Table***\n");
     symrec_foreach((int (*) (symrec *))symrec_print);
 
+    symrec_parser_finalize();
     sections_parser_finalize(sections);
 
     printf("Post-parser-finalization:\n");

diff --git a/src/symrec.c b/src/symrec.c
index a2700ffeb565244e5d603f82a6188d81bad91ad7..46db876e44fd806eb7fd503502011acb3f20b813 100644 (file)
--- a/src/symrec.c
+++ b/src/symrec.c
@@ -243,6 +243,26 @@ symrec_get_equ(const symrec *sym)
     return (const expr *)NULL;
 }
 
+static int
+symrec_parser_finalize_checksym(symrec *sym)
+{
+    /* error if a symbol is used but never defined */
+    if ((sym->status & SYM_USED) && !(sym->status & SYM_DEFINED)) {
+       ErrorAt(sym->filename, sym->line,
+               _("undefined symbol `%s' (first use)"), sym->name);
+       ErrorAt(sym->filename, sym->line,
+               _("(Each undefined symbol is reported only once.)"));
+       return 0;
+    } else
+       return 1;
+}
+
+void
+symrec_parser_finalize(void)
+{
+    symrec_foreach(symrec_parser_finalize_checksym);
+}
+
 void
 symrec_print(const symrec *sym)
 {

diff --git a/src/symrec.h b/src/symrec.h
index e87e7f193c2ad0249b5b4b70d102acb12f51eace..60ed516e79eeee85db812266f2e8ed95e6a907e9 100644 (file)
--- a/src/symrec.h
+++ b/src/symrec.h
@@ -72,5 +72,7 @@ const expr *symrec_get_equ(const symrec *sym);
 
 int symrec_foreach(int (*func) (symrec *sym));
 
+void symrec_parser_finalize(void);
+
 void symrec_print(const symrec *sym);
 #endif