issue 4301: patch logging to add processName, remove the old _check_logger_class...

diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py
index 513d4dce41f6f9db3701fe9738cce56cfbbc9086..c77cde3955ffdfd48bf23f2a17ad83befbb1a061 100644 (file)
--- a/Lib/logging/__init__.py
+++ b/Lib/logging/__init__.py
@@ -99,6 +99,11 @@ raiseExceptions = 1
 #
 logThreads = 1
 
+#
+# If you don't want multiprocessing information in the log, set this to zero
+#
+logMultiprocessing = 1
+
 #
 # If you don't want process information in the log, set this to zero
 #
@@ -266,6 +271,11 @@ class LogRecord:
         else:
             self.thread = None
             self.threadName = None
+        if logMultiprocessing:
+            from multiprocessing import current_process
+            self.processName = current_process().name
+        else:
+            self.processName = None
         if logProcesses and hasattr(os, 'getpid'):
             self.process = os.getpid()
         else:

diff --git a/Lib/multiprocessing/util.py b/Lib/multiprocessing/util.py
index 7d53512725c77bcfcbeba0929ae33d474df2e65d..2e7a2ac2067ab2307af525a91b9899319505e515 100644 (file)
--- a/Lib/multiprocessing/util.py
+++ b/Lib/multiprocessing/util.py
@@ -69,34 +69,10 @@ def get_logger():
             atexit._exithandlers.remove((_exit_function, (), {}))
             atexit._exithandlers.append((_exit_function, (), {}))
 
-        _check_logger_class()
         _logger = logging.getLogger(LOGGER_NAME)
 
     return _logger
 
-def _check_logger_class():
-    '''
-    Make sure process name is recorded when loggers are used
-    '''
-    # XXX This function is unnecessary once logging is patched
-    import logging
-    if hasattr(logging, 'multiprocessing'):
-        return
-
-    logging._acquireLock()
-    try:
-        OldLoggerClass = logging.getLoggerClass()
-        if not getattr(OldLoggerClass, '_process_aware', False):
-            class ProcessAwareLogger(OldLoggerClass):
-                _process_aware = True
-                def makeRecord(self, *args, **kwds):
-                    record = OldLoggerClass.makeRecord(self, *args, **kwds)
-                    record.processName = current_process()._name
-                    return record
-            logging.setLoggerClass(ProcessAwareLogger)
-    finally:
-        logging._releaseLock()
-
 def log_to_stderr(level=None):
     '''
     Turn on logging and add a handler which prints to stderr

diff --git a/Misc/NEWS b/Misc/NEWS
index f333a9238b92ad2f985a8150aa56fb521ad08257..2ed95a5ec516a39596ac5c4bc31f95c6050e9dd7 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -596,6 +596,9 @@ Library
 Extension Modules
 -----------------
 
+- Issue #4301: Patch the logging module to add processName support, remove
+  _check_logger_class from multiprocessing.
+
 - Issue #2975: When compiling several extension modules with Visual Studio 2008
   from the same python interpreter, some environment variables would grow
   without limit.