Merged revisions 79268 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r79268 | michael.foord | 2010-03-21 20:41:11 -0500 (Sun, 21 Mar 2010) | 1 line

  Removing Python 2.3 compatibility code from unittest.
........

diff --git a/Lib/test/test_unittest.py b/Lib/test/test_unittest.py
index c8fc43965a390a4a25b36d63e83e36b834c6a1f2..a88d75b6897e5593fbc977c1d17998e806a93a8d 100644 (file)
--- a/Lib/test/test_unittest.py
+++ b/Lib/test/test_unittest.py
@@ -3991,13 +3991,15 @@ class TestDiscovery(TestCase):
         program._do_discovery(['-p', 'fish'], Loader=Loader)
         self.assertEqual(program.test, 'tests')
         self.assertEqual(Loader.args, [('.', 'fish', None)])
+        self.assertFalse(program.failfast)
 
         Loader.args = []
         program = object.__new__(TestProgram)
-        program._do_discovery(['-p', 'eggs', '-s', 'fish', '-v'], Loader=Loader)
+        program._do_discovery(['-p', 'eggs', '-s', 'fish', '-v', '-f'], Loader=Loader)
         self.assertEqual(program.test, 'tests')
         self.assertEqual(Loader.args, [('fish', 'eggs', None)])
         self.assertEqual(program.verbosity, 2)
+        self.assertTrue(program.failfast)
 
 
 class TestSetups(unittest.TestCase):

diff --git a/Lib/unittest/loader.py b/Lib/unittest/loader.py
index eea5c13366a1f14976a9730e333400cfa6995595..5d11b6e8ffd1c8f9c9bcafac9981946f9e7ab6e8 100644 (file)
--- a/Lib/unittest/loader.py
+++ b/Lib/unittest/loader.py
@@ -19,11 +19,7 @@ VALID_MODULE_NAME = re.compile(r'[_a-z]\w*\.py$', re.IGNORECASE)
 
 
 def _make_failed_import_test(name, suiteClass):
-    message = 'Failed to import test module: %s' % name
-    if hasattr(traceback, 'format_exc'):
-        # Python 2.3 compatibility
-        # format_exc returns two frames of discover.py as well
-        message += '\n%s' % traceback.format_exc()
+    message = 'Failed to import test module: %s\n%s' % (name, traceback.format_exc())
     return _make_failed_test('ModuleImportFailure', name, ImportError(message),
                              suiteClass)
 

diff --git a/Lib/unittest/main.py b/Lib/unittest/main.py
index 63fbd160812696359e54502ff5a14fc59d203c0b..1db7978db6355d93a4eb477bb8448c5747c5ef49 100644 (file)
--- a/Lib/unittest/main.py
+++ b/Lib/unittest/main.py
@@ -159,10 +159,9 @@ class TestProgram(object):
         for name, value in zip(('start', 'pattern', 'top'), args):
             setattr(options, name, value)
 
+        self.failfast = options.failfast
         if options.verbose:
             self.verbosity = 2
-        if options.failfast:
-            self.failfast = True
 
         start_dir = options.start
         pattern = options.pattern