]> granicus.if.org Git - graphviz/commitdiff
CI: also apply ASan, UBSan options to ld flags
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Wed, 16 Nov 2022 05:29:14 +0000 (21:29 -0800)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Wed, 16 Nov 2022 15:49:52 +0000 (07:49 -0800)
The test job was doing this but the build job was not. Technically I think this
is unnecessary (I think CMake includes `CFLAGS` or `CXXFLAGS` when calling `ld`)
but it seems worth being consistent.

.gitlab-ci.yml

index fde01d34b5ffaf1fed08cdfe3142a84b0bf0e33b..8d2f500a2798d7537ea08509b4e100dc972033f8 100644 (file)
@@ -775,6 +775,7 @@ ubuntu-22.10-cmake-ASan-build-for-ctest:
         # fail on any compiler warnings
         - export CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=address,undefined -g -Werror"
         - export CXXFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=address,undefined -g -Werror"
+        - export LDFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=address,undefined -g -Werror"
         - export CMAKE_OPTIONS="-Duse_coverage=ON -Dwith_cxx_tests=ON -Dwith_cxx_api=ON"
         - export CMAKE_OPTIONS="$CMAKE_OPTIONS -Dwith_smyrna=ON"
     # override the deb_build_definition artifacts since we need more