* libmisc/loginprompt.c: Prefer snprintf to sprintf, even if a

	small context indicates no issues.

diff --git a/ChangeLog b/ChangeLog
index b674c4855fd7e7ee4e71bada4066c65979dd8234..dc7c4307b7c532429fb23da2a1368877b2084774 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-04-25  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * libmisc/loginprompt.c: Prefer snprintf to sprintf, even if a
+       small context indicates no issues.
+
 2009-04-25  Nicolas François  <nicolas.francois@centraliens.net>
 
        * src/faillog.c: Remove function calls from within assert().

diff --git a/libmisc/loginprompt.c b/libmisc/loginprompt.c
index 1d968d760400dfc8abd431cc969c0573762d904e..bcc42b36a180ae90b75ddc71d4ad3ffaa8f1d4a4 100644 (file)
--- a/libmisc/loginprompt.c
+++ b/libmisc/loginprompt.c
@@ -156,8 +156,9 @@ void login_prompt (const char *prompt, char *name, int namesize)
                        if (strchr (nvar, '=') != NULL) {
                                envp[envc] = nvar;
                        } else {
-                               envp[envc] = xmalloc (strlen (nvar) + 32);
-                               sprintf (envp[envc], "L%d=%s", count++, nvar);
+                               size_t len = strlen (nvar) + 32;
+                               envp[envc] = xmalloc (len);
+                               snprintf (envp[envc], len, "L%d=%s", count++, nvar);
                        }
                }
                set_env (envc, envp);